Re: [PATCH 2/4] pmdomain: sunxi: sun20i-ppu: add A523 support

[Andre Przywara <andre.przywara@arm.com>]

On Fri, 27 Jun 2025 23:29:16 +0800
Chen-Yu Tsai <wens@kernel.org> wrote:

> From: Chen-Yu Tsai <wens@csie.org>
> 
> A523 has a PPU like the one in the Allwinner D1 SoC.
> 
> Add a compatible entry and a list of power domain names for it.

The user manual does not describe this PPU, but the BSP code confirms
the order of the domains, so:

> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

One suggestion below, but only if you respin anyway:

> ---
>  drivers/pmdomain/sunxi/sun20i-ppu.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/pmdomain/sunxi/sun20i-ppu.c b/drivers/pmdomain/sunxi/sun20i-ppu.c
> index 9f002748d224..b65876a68cc1 100644
> --- a/drivers/pmdomain/sunxi/sun20i-ppu.c
> +++ b/drivers/pmdomain/sunxi/sun20i-ppu.c
> @@ -193,6 +193,19 @@ static const struct sun20i_ppu_desc sun8i_v853_ppu_desc = {
>  	.num_domains	= ARRAY_SIZE(sun8i_v853_ppu_pd_names),
>  };
>  
> +static const char *const sun55i_a523_ppu_pd_names[] = {
> +	"DSP",

I wonder if we should enforce the relation between the DT binding
symbols and the names here, like:

	[PD_DSP] = "DSP",
	[PD_NPU] = "NPU",
	...

Cheers,
Andre


> +	"NPU",
> +	"AUDIO",
> +	"SRAM",
> +	"RISCV",
> +};
> +
> +static const struct sun20i_ppu_desc sun55i_a523_ppu_desc = {
> +	.names		= sun55i_a523_ppu_pd_names,
> +	.num_domains	= ARRAY_SIZE(sun55i_a523_ppu_pd_names),
> +};
> +
>  static const struct of_device_id sun20i_ppu_of_match[] = {
>  	{
>  		.compatible	= "allwinner,sun20i-d1-ppu",
> @@ -202,6 +215,10 @@ static const struct of_device_id sun20i_ppu_of_match[] = {
>  		.compatible	= "allwinner,sun8i-v853-ppu",
>  		.data		= &sun8i_v853_ppu_desc,
>  	},
> +	{
> +		.compatible	= "allwinner,sun55i-a523-ppu",
> +		.data		= &sun55i_a523_ppu_desc,
> +	},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, sun20i_ppu_of_match);