From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99F14C8303C for ; Mon, 7 Jul 2025 09:01:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 553A3413DF; Mon, 7 Jul 2025 09:01:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id M2ga9JzMtk1L; Mon, 7 Jul 2025 09:01:14 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7EF1640EF5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1751878874; bh=e9SWFcb0msrjB6idocXhvC6mvsfdigDERKcSsgUav9E=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=yrp5BX4RqlkVL+HhMgSFF2L4vD5BuXoMpnu4bUbyR2nFLKvEVns7B5SwE2WpjjO9n aQESGnpSnKHfZ1gJACVVj3eDpHpgAUNDDbDX8rOSk+OdXpXia/9RdnTYtAzg33CJ9g c+WNvnG9pyLF0MkKamL2+HMy2h8ytwCVr6wTV3/DGX23B5e5Y4Jt2eKMV2iRPkNcvY 6FovHWNDR0C+PANp64Kjuk2fVYIwI3mFzVBn3E+TRcIvYYQ4rW5pC1r+GIBnGHfBPH N0U1eYlLnbyQYcPmHkl7W2IDvkXCtZMcyjv/GVgnIsnMpHRSVnS9waaSGD7gwZBgOt OVcVW8zFRJ1nQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 7EF1640EF5; Mon, 7 Jul 2025 09:01:14 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 90F9412E for ; Mon, 7 Jul 2025 09:01:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7753A40C0E for ; Mon, 7 Jul 2025 09:01:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id BzwfA1n-yMKn for ; Mon, 7 Jul 2025 09:01:11 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 734BC4141F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 734BC4141F Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp4.osuosl.org (Postfix) with ESMTPS id 734BC4141F for ; Mon, 7 Jul 2025 09:01:11 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 962D861130; Mon, 7 Jul 2025 09:01:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1A0AC4CEE3; Mon, 7 Jul 2025 09:01:06 +0000 (UTC) Date: Mon, 7 Jul 2025 10:01:04 +0100 From: Simon Horman To: Haoxiang Li Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michal Swiatkowski , Aleksandr Loktionov Message-ID: <20250707090104.GB89747@horms.kernel.org> References: <20250703095232.2539006-1-haoxiang_li2024@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250703095232.2539006-1-haoxiang_li2024@163.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751878869; bh=24gyF1taVTxprKDEd+rLNk+GtDDxWmbXhwmk849/WWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cwuIO+MiSF26xvbooegOGFArbkFQbJeMsk1yK4RPMXoLyRDKVgFGsod9UHyUoiJlm mgweD/93f6A+xjoYBX8uTrg225ptbSCuzwSXViwV7ZWFrMnKFk/y9Hh0HOa2MdyL3T 0VAXkNAJIBLEjY6DmMRE7GS0ZUQsF8P8FuvVXFR0s7taBMmHxLD+mZtb/9CSULctf2 C9XOsddfAPrDx5PObrvCF+DuVpUUn56lMyNT/XVx3MEYHT0Pk2aGzDwmDIdCR7/lc9 9jPaxE4TD4r5JkdOdwh9brdRrSv6CfnT1LCdLujxnJ2v92CeM5q1D2RfXjuiS9fljv w6gPVmTb0XxTQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cwuIO+Mi Subject: Re: [Intel-wired-lan] [PATCH v2] ice: Fix a null pointer dereference in ice_copy_and_init_pkg() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jul 03, 2025 at 05:52:32PM +0800, Haoxiang Li wrote: > Add check for the return value of devm_kmemdup() > to prevent potential null pointer dereference. > > Fixes: c76488109616 ("ice: Implement Dynamic Device Personalization (DDP) download") > Cc: stable@vger.kernel.org > Signed-off-by: Haoxiang Li > Reviewed-by: Michal Swiatkowski > Reviewed-by: Aleksandr Loktionov > --- > Changes in v2: > - modify the Fixes commit number. Thanks, Michal! Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4CBB19F421; Mon, 7 Jul 2025 09:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751878869; cv=none; b=nMQKtD01x75iDfakbboxgsK3QwMbYcEm0yRbOOh/z0HnuZtEKdaWdbbNKYg+zSpPP4MMQMv9qx7Omb5JWqTmOVdPaSyF9ecCTeHhgSaKGHi3eKXkEqMIoTM+56fnh0/EBECDsRhze9xyIG/KYjFlJ4sdffZWRX7oKfhxredyzBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751878869; c=relaxed/simple; bh=24gyF1taVTxprKDEd+rLNk+GtDDxWmbXhwmk849/WWI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E8fzZBSHiXldhH4SIrTwq6C41qhv3uAH54OCiqZMT9YJEWaApn/F/Dcr6h3WdnTCUcionsgtlBqYynnbzRG9hbEhDrFXwg4EQchDZNjXFP0pQCB+dREDpJ+9K9E2j1biRN5tEA5lmVGW8+vYcf2t6HIRXlPgAoA7lFSkwe9e90Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cwuIO+Mi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cwuIO+Mi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1A0AC4CEE3; Mon, 7 Jul 2025 09:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751878869; bh=24gyF1taVTxprKDEd+rLNk+GtDDxWmbXhwmk849/WWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cwuIO+MiSF26xvbooegOGFArbkFQbJeMsk1yK4RPMXoLyRDKVgFGsod9UHyUoiJlm mgweD/93f6A+xjoYBX8uTrg225ptbSCuzwSXViwV7ZWFrMnKFk/y9Hh0HOa2MdyL3T 0VAXkNAJIBLEjY6DmMRE7GS0ZUQsF8P8FuvVXFR0s7taBMmHxLD+mZtb/9CSULctf2 C9XOsddfAPrDx5PObrvCF+DuVpUUn56lMyNT/XVx3MEYHT0Pk2aGzDwmDIdCR7/lc9 9jPaxE4TD4r5JkdOdwh9brdRrSv6CfnT1LCdLujxnJ2v92CeM5q1D2RfXjuiS9fljv w6gPVmTb0XxTQ== Date: Mon, 7 Jul 2025 10:01:04 +0100 From: Simon Horman To: Haoxiang Li Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michal Swiatkowski , Aleksandr Loktionov Subject: Re: [PATCH v2] ice: Fix a null pointer dereference in ice_copy_and_init_pkg() Message-ID: <20250707090104.GB89747@horms.kernel.org> References: <20250703095232.2539006-1-haoxiang_li2024@163.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250703095232.2539006-1-haoxiang_li2024@163.com> On Thu, Jul 03, 2025 at 05:52:32PM +0800, Haoxiang Li wrote: > Add check for the return value of devm_kmemdup() > to prevent potential null pointer dereference. > > Fixes: c76488109616 ("ice: Implement Dynamic Device Personalization (DDP) download") > Cc: stable@vger.kernel.org > Signed-off-by: Haoxiang Li > Reviewed-by: Michal Swiatkowski > Reviewed-by: Aleksandr Loktionov > --- > Changes in v2: > - modify the Fixes commit number. Thanks, Michal! Reviewed-by: Simon Horman