From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
andrew@lunn.ch, przemyslaw.kitszel@intel.com,
anthony.l.nguyen@intel.com, sgoutham@marvell.com,
gakula@marvell.com, sbhatta@marvell.com, bbhushan2@marvell.com,
tariqt@nvidia.com, mbloch@nvidia.com, leon@kernel.org,
ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next v2 3/5] eth: mlx5: migrate to the *_rxfh_context ops
Date: Mon, 7 Jul 2025 11:19:36 -0700 [thread overview]
Message-ID: <20250707111936.05b858b6@kernel.org> (raw)
In-Reply-To: <b5f66ba0-7d1c-4228-b0ec-f62aca289b23@nvidia.com>
On Thu, 3 Jul 2025 15:22:41 +0300 Gal Pressman wrote:
> > -int mlx5e_rss_get_rxfh(struct mlx5e_rss *rss, u32 *indir, u8 *key, u8 *hfunc, bool *symmetric)
> > +void mlx5e_rss_get_rxfh(struct mlx5e_rss *rss, u32 *indir, u8 *key, u8 *hfunc,
> > + bool *symmetric)
>
> I assume this doesn't compile, you didn't remove the return statement at
> the end of the function.
My bad. I was build testing drivers/net/ethernet/mellanox/mlx5/ which
doesn't have a Makefile..
next prev parent reply other threads:[~2025-07-07 18:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 3:06 [PATCH net-next v2 0/5] net: migrate remaining drivers to dedicated _rxfh_context ops Jakub Kicinski
2025-07-02 3:06 ` [PATCH net-next v2 1/5] eth: otx2: migrate to the *_rxfh_context ops Jakub Kicinski
2025-07-04 7:14 ` [EXTERNAL] " Geethasowjanya Akula
2025-07-02 3:06 ` [PATCH net-next v2 2/5] eth: ice: drop the dead code related to rss_contexts Jakub Kicinski
2025-07-02 3:06 ` [PATCH net-next v2 3/5] eth: mlx5: migrate to the *_rxfh_context ops Jakub Kicinski
2025-07-03 12:22 ` Gal Pressman
2025-07-07 18:19 ` Jakub Kicinski [this message]
2025-07-03 17:35 ` kernel test robot
2025-07-05 3:24 ` kernel test robot
2025-07-02 3:06 ` [PATCH net-next v2 4/5] net: ethtool: remove the compat code for _rxfh_context ops Jakub Kicinski
2025-07-02 18:54 ` Edward Cree
2025-07-02 3:06 ` [PATCH net-next v2 5/5] net: ethtool: reduce indent " Jakub Kicinski
2025-07-02 18:57 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707111936.05b858b6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=leon@kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.