From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69A1DC71130 for ; Mon, 7 Jul 2025 18:13:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uYqJb-0005st-PE; Mon, 07 Jul 2025 14:11:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uYq1i-00023k-8p for qemu-arm@nongnu.org; Mon, 07 Jul 2025 13:53:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uYq1g-0000r8-2G for qemu-arm@nongnu.org; Mon, 07 Jul 2025 13:53:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751910789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eb6zWc3B+Sf8gBWy0KrYt+o+lZJy7X8T0crcOBFjgiA=; b=NIJiA4VZtbqWlzewo+DFmtDatocUAGigU/gBNmgdxttIkNW/mdrn3bnv0xUH3XQjSNQ2yn LHL5rGLSYfP8c9+hB0UHzWLbOHuP5Vdvr+n2CoUfTviq4ozqCdK/WWbqiPx8lBVbmJAOO8 y5OBcNgxFQsiGa52a9lsm5rsJSCu4/I= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-q2aApTTfPTueDrWryzyloA-1; Mon, 07 Jul 2025 13:53:08 -0400 X-MC-Unique: q2aApTTfPTueDrWryzyloA-1 X-Mimecast-MFC-AGG-ID: q2aApTTfPTueDrWryzyloA_1751910787 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-453691d0a1dso18788265e9.0 for ; Mon, 07 Jul 2025 10:53:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751910787; x=1752515587; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eb6zWc3B+Sf8gBWy0KrYt+o+lZJy7X8T0crcOBFjgiA=; b=MCzFNmWCyuMPD86+4j6o6Skb8YmSZJSeCjF6h3mV+aeWknGQ/RlOe+KpiEaXzKEbBo 8f871HT1co8MN9j8xQHtONl+/4BGDU1neFc4L/62pO7ohSxfs+u0674Ra9856kqYhcIo DB23RBzrl8Atg7s48oT/iWtoTqLJEXNTXr9eNoniSxMRTLSzdBLjRc2R3cKsdZa7xgKs pNYdQeHYGhaGJz5OhqQv4Tkbhvpx4o7OQShPrsW8lWeq5C8cAV+aluniQ8nhjr5AVFzk 4ElV2JFh3iw76U/PTnuXX2j/TE0DkrhQRZTx4tYhJS5yBprK+nSME1nGall8Dlp3C8HX Izjw== X-Forwarded-Encrypted: i=1; AJvYcCWWGSJgq95LkwbjOj9An8lI2ffLN7zX3sWszbLAg+cKzROS36KhO6afWvgSoUu5w0bBZ2uEqlfEvA==@nongnu.org X-Gm-Message-State: AOJu0YzGU5u86aOH5o51gO77gygeLGBs3PEg57WWhAXZmYbMF8D/ywNp FtTabGTK7GDfah72ctTAI3gwdln4jjTIfMn0p2Ab9msQx3H+3Paldz+NPvYuvG8ByObNgG5trqb 8Z7/vvH+HM3kt5zJF1Ge5wS/wWmrQfox2Wsa/Y4VFsLbTw/HcolUbZQ== X-Gm-Gg: ASbGncvlZSwq9ekRfH9rVTHcDTQ3pA84u/X3eSpRPRwchCQSpkGpRIu8+TfED7+gzkK Lc7LQz6E2e/KNU/2nt+RwzceMRc5sBFhMElV/xLpkiJ8rRdaxBeNKGeOrZyaQDL1cEjVIdJPua0 2gPnRqyTCz2R/lubFHWWlTsN7HzlP2DMtFRyy4wvlkhhDrEuSGhQmDmtWoZ/R0+nfDR/htYyWNW c3qI0InmJQxoaaZPc5YhCvXiyCdh6nRLPqeoOPa0qAbYOCQDJWo9rhyRQC2JBq0dlnkkgizm5UW V5AYjpU4tbfJhEM= X-Received: by 2002:a05:600c:64ce:b0:450:cfe1:a827 with SMTP id 5b1f17b1804b1-454b4ec4deamr129571785e9.31.1751910787036; Mon, 07 Jul 2025 10:53:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5LYaRybavsoD2Eawpr1dUoQMVtAVtCg47udLVAariNBMNBkwz2gXGUl0FlwmdMqHoATKYDQ== X-Received: by 2002:a05:600c:64ce:b0:450:cfe1:a827 with SMTP id 5b1f17b1804b1-454b4ec4deamr129571475e9.31.1751910786550; Mon, 07 Jul 2025 10:53:06 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:150d:fc00:de3:4725:47c6:6809]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9be0bacsm146088995e9.32.2025.07.07.10.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 10:53:06 -0700 (PDT) Date: Mon, 7 Jul 2025 13:53:03 -0400 From: "Michael S. Tsirkin" To: Eric Auger Cc: eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, imammedo@redhat.com, Jonathan.Cameron@huawei.com, gustavo.romero@linaro.org, anisinha@redhat.com, shannon.zhaosl@gmail.com, pbonzini@redhat.com, philmd@linaro.org, alex.bennee@linaro.org Subject: Re: [PATCH v5 00/36] ACPI PCI Hotplug support on ARM Message-ID: <20250707135106-mutt-send-email-mst@kernel.org> References: <20250703123728.414386-1-eric.auger@redhat.com> <152beeb2-7de7-4a4b-8f5d-806e7f18dda6@redhat.com> MIME-Version: 1.0 In-Reply-To: <152beeb2-7de7-4a4b-8f5d-806e7f18dda6@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YqXwHHrdYGZv4oSAMbEh50rnhIlgOvYwiZgQBxsy7B0_1751910787 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Mon, Jul 07, 2025 at 07:09:34PM +0200, Eric Auger wrote: > Hi, > > On 7/3/25 2:35 PM, Eric Auger wrote: > > This series enables ACPI PCI hotplug/hotunplug on ARM. > > It is not enabled by default and ACPI PCI hotplug can > > be selected by setting: > > > > -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > > > > Expected benefits should be similar to those listed in [1], > > ie. removal of some racy behaviors, improved latencies. > > > > The infrastructure used in x86 is heavily reused and a > > huge part of the series consists in moving code from > > hw/i386/acpi-build.c to a generic place and slightly > > adapting it to make it usable on ARM. The DSDT table is > > augmented to support ACPI PCI hotplug elements. > > > > On ARM we use use a GED event to notify the OS about > > hotplug events. > > gentle ping on this series. I was hoping that this could target 10.1 but > I ackowledge this is a big series to review and I am already very > grateful to all reviewers. > > At least patches 1-15 have collected R-bs including Igor's ones. They > can be seen as code move/reshuffle/cleanup and does not bring any > functionality. I think patches 16-19 also belong to prerequisite and > fixes and are easy to parse. > So if we could at least have patches 1-19 merged in 10.1, this would > alleviate the rebase efforts for next respins if any. > > Of course I have not totally lost all hopes to get this in in 10.1 ;-) > and I will be able to diligently respin upon comments. > > Thanks > > Eric If no one objects, I can queue this. OK with ARM maintainers? I think the only comment I have is shorter/cropped commit logs for the blobs, that Jonathan already pointed out. Want to respin doing that? > > > > Best Regards > > > > Eric > > > > This series can be found at: > > https://github.com/eauger/qemu/tree/arm-acpi-pcihp-v5 > > > > previous series: > > https://github.com/eauger/qemu/tree/arm-acpi-pcihp-v4 > > > > History: > > v4 -> v5: > > - Collected Jonathan's R-bs (many thanks!) > > - fixed the tests/qtest/bios-tables-test issue by > > creating a variant for the viot test > > - use the 3 phase reset API > > - fixed qom-test failures that were due to unconditionnal > > fetches of the GED property > > > > v3 -> v4: > > - toook into account all comments on v3 > > - static acpi-index is now supported unconditionally > > from acpi pcihp option. See indiviual patches. > > - I hit a problem with ref block generation at > > [19/32] tests/qtest/bios-tables-test: Update ARM DSDT reference > > blobs: despite I regenerate the blobs, I get some errors. > > > > v2 -> v3: > > - lot of changes taking into account various feedbacks > > (many thanks to all reviewers). Please refer to > > individual patches for details. Main changes: > > - no more machine option, acpi pci hp is not set by > > default. > > - removal of 2 unused variables in the osc method > > - introduction of GED property to set the bus > > - rework of the init/reset sequence > > - fix virtio-mem-pci hotplug regression > > > > v1 -> v2: > > - collected a bunch of R-bs from Gustavo (many thanks!) > > - Fixed the breakage of bios-tables-test in TCG mode by > > incorporating Gustavo's patches (part of > > [PATCH 0/5] ACPI tests for PCI Hotplug on ARM > > https://lore.kernel.org/all/20250526053123.1434204-1-gustavo.romero@linaro.org/) > > - Tweeked the dsdt aml changes to avoid any dsdt blob difference when > > acpi-pcihp is off. > > > > RFC -> v1: > > - First 3 trivial patches were pulled separately > > - Fix of the register region size (0x18), ie. ACPI_PCIHP_SIZE > > - addition of aml_pci_edsm which was not called in RFC > > - acpi-index feature is now fixed. vms->bus was not set on > > acpi_pcihp_init. The init sequence is still hacky though. Suggestions > > are welcome. > > > > [1] [PATCH v6 0/6] Use ACPI PCI hot-plug for Q35 > > https://lore.kernel.org/all/20210713004205.775386-1-jusual@redhat.com/ > > > > > > Eric Auger (32): > > hw/i386/acpi-build: Make aml_pci_device_dsm() static > > hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp > > hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to > > acpi_dsdt_add_pci_osc > > hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation > > hw/acpi/ged: Add a acpi-pci-hotplug-with-bridge-support property > > hw/pci-host/gpex-acpi: Use GED acpi pcihp property > > hw/i386/acpi-build: Turn build_q35_osc_method into a generic method > > hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method > > tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change > > hw/i386/acpi-build: Introduce build_append_pcihp_resources() helper > > hw/acpi/pcihp: Add an AmlRegionSpace arg to build_acpi_pci_hotplug > > hw/i386/acpi-build: Move build_append_notification_callback to pcihp > > hw/i386/acpi-build: Move build_append_pci_bus_devices/pcihp_slots to > > pcihp > > hw/i386/acpi-build: Use AcpiPciHpState::root in acpi_set_pci_info > > hw/i386/acpi-build: Move aml_pci_edsm to a generic place > > qtest/bios-tables-test: Prepare for fixing the aarch64 viot test > > qtest/bios-tables-test: Add a variant to the aarch64 viot test > > qtest/bios-tables-test: Generate DSDT.viot > > hw/arm/virt-acpi-build: Let non hotplug ports support static > > acpi-index > > tests/qtest/bios-tables-test: Update ARM DSDT reference blobs > > hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI > > hotplug > > hw/acpi/ged: Add a bus link property > > hw/arm/virt: Pass the bus on the ged creation > > hw/acpi/ged: Call pcihp plug callbacks in hotplug handler > > implementation > > hw/acpi/pcihp: Remove root arg in acpi_pcihp_init > > hw/acpi/ged: Prepare the device to react to PCI hotplug events > > hw/acpi/ged: Support migration of AcpiPciHpState > > hw/core/sysbus: Introduce sysbus_mmio_map_name() helper > > hw/arm/virt: Minor code reshuffling in create_acpi_ged > > hw/arm/virt: Let virt support pci hotplug/unplug GED event > > qtest/bios-tables-test: Generate reference blob for > > DSDT.hpoffacpiindex > > qtest/bios-tables-test: Generate reference blob for DSDT.acpipcihp > > > > Gustavo Romero (4): > > tests/qtest/bios-tables-test: Prepare for changes in the DSDT table > > tests/qtest/bios-tables-test: Prepare for changes in the arm virt DSDT > > table > > tests/qtest/bios-tables-test: Prepare for addition of acpi pci hp > > tests > > tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test > > > > hw/i386/acpi-build.h | 4 - > > include/hw/acpi/generic_event_device.h | 17 +- > > include/hw/acpi/pci.h | 5 +- > > include/hw/acpi/pcihp.h | 17 +- > > include/hw/arm/virt.h | 1 + > > include/hw/pci-host/gpex.h | 1 + > > include/hw/sysbus.h | 1 + > > hw/acpi/acpi-pci-hotplug-stub.c | 2 +- > > hw/acpi/generic_event_device.c | 77 +++ > > hw/acpi/ich9.c | 7 +- > > hw/acpi/pci-bridge.c | 54 ++ > > hw/acpi/pci.c | 50 ++ > > hw/acpi/pcihp.c | 439 ++++++++++++++- > > hw/acpi/piix4.c | 5 +- > > hw/arm/virt-acpi-build.c | 38 ++ > > hw/arm/virt.c | 27 +- > > hw/core/sysbus.c | 11 + > > hw/i386/acpi-build.c | 532 +----------------- > > hw/pci-host/gpex-acpi.c | 74 +-- > > tests/qtest/bios-tables-test.c | 53 ++ > > hw/arm/Kconfig | 2 + > > hw/pci-host/Kconfig | 1 + > > tests/data/acpi/aarch64/virt/DSDT | Bin 5196 -> 5293 bytes > > .../data/acpi/aarch64/virt/DSDT.acpihmatvirt | Bin 5282 -> 5379 bytes > > tests/data/acpi/aarch64/virt/DSDT.acpipcihp | Bin 0 -> 6202 bytes > > .../acpi/aarch64/virt/DSDT.hpoffacpiindex | Bin 0 -> 5347 bytes > > tests/data/acpi/aarch64/virt/DSDT.memhp | Bin 6557 -> 6654 bytes > > tests/data/acpi/aarch64/virt/DSDT.pxb | Bin 7679 -> 7768 bytes > > tests/data/acpi/aarch64/virt/DSDT.topology | Bin 5398 -> 5495 bytes > > tests/data/acpi/aarch64/virt/DSDT.viot | Bin 0 -> 5310 bytes > > tests/data/acpi/riscv64/virt/DSDT | Bin 3576 -> 3538 bytes > > tests/data/acpi/x86/microvm/DSDT.pcie | Bin 3023 -> 2985 bytes > > 32 files changed, 811 insertions(+), 607 deletions(-) > > create mode 100644 tests/data/acpi/aarch64/virt/DSDT.acpipcihp > > create mode 100644 tests/data/acpi/aarch64/virt/DSDT.hpoffacpiindex > > create mode 100644 tests/data/acpi/aarch64/virt/DSDT.viot > >