Re: [PATCH rdma-next 7/8] IB: Extend UVERBS_METHOD_REG_MR to get DMAH

[Leon Romanovsky <leon@kernel.org>]

On Tue, Jul 08, 2025 at 10:27:42AM +0800, Junxian Huang wrote:
> 
> 
> On 2025/7/8 1:03, Leon Romanovsky wrote:
> > From: Yishai Hadas <yishaih@nvidia.com>
> > 
> > Extend UVERBS_METHOD_REG_MR to get DMAH and pass it to all drivers.
> > 
> > It will be used in mlx5 driver as part of the next patch from the
> > series.
> > 
> > Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
> > Reviewed-by: Edward Srouji <edwards@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> >  drivers/infiniband/core/uverbs_cmd.c          |  2 +-
> >  drivers/infiniband/core/uverbs_std_types_mr.c | 21 ++++++++++++++++---
> >  drivers/infiniband/core/verbs.c               |  5 ++++-
> >  drivers/infiniband/hw/bnxt_re/ib_verbs.c      |  8 +++++++
> >  drivers/infiniband/hw/bnxt_re/ib_verbs.h      |  2 ++
> >  drivers/infiniband/hw/cxgb4/iw_cxgb4.h        |  1 +
> >  drivers/infiniband/hw/cxgb4/mem.c             |  6 +++++-
> >  drivers/infiniband/hw/efa/efa.h               |  2 ++
> >  drivers/infiniband/hw/efa/efa_verbs.c         |  8 +++++++
> >  drivers/infiniband/hw/erdma/erdma_verbs.c     |  6 +++++-
> >  drivers/infiniband/hw/erdma/erdma_verbs.h     |  3 ++-
> >  drivers/infiniband/hw/hns/hns_roce_device.h   |  1 +
> >  drivers/infiniband/hw/hns/hns_roce_mr.c       |  4 ++++
> >  drivers/infiniband/hw/irdma/verbs.c           |  9 ++++++++
> >  drivers/infiniband/hw/mana/mana_ib.h          |  2 ++
> >  drivers/infiniband/hw/mana/mr.c               |  8 +++++++
> >  drivers/infiniband/hw/mlx4/mlx4_ib.h          |  1 +
> >  drivers/infiniband/hw/mlx4/mr.c               |  4 ++++
> >  drivers/infiniband/hw/mlx5/mlx5_ib.h          |  2 ++
> >  drivers/infiniband/hw/mlx5/mr.c               |  8 ++++---
> >  drivers/infiniband/hw/mthca/mthca_provider.c  |  6 +++++-
> >  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c   |  6 +++++-
> >  drivers/infiniband/hw/ocrdma/ocrdma_verbs.h   |  3 ++-
> >  drivers/infiniband/hw/qedr/verbs.c            |  6 +++++-
> >  drivers/infiniband/hw/qedr/verbs.h            |  3 ++-
> >  drivers/infiniband/hw/usnic/usnic_ib_verbs.c  |  4 ++++
> >  drivers/infiniband/hw/usnic/usnic_ib_verbs.h  |  1 +
> >  drivers/infiniband/hw/vmw_pvrdma/pvrdma_mr.c  |  5 +++++
> >  .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h   |  1 +
> >  drivers/infiniband/sw/rdmavt/mr.c             |  5 +++++
> >  drivers/infiniband/sw/rdmavt/mr.h             |  1 +
> >  drivers/infiniband/sw/rxe/rxe_verbs.c         |  4 ++++
> >  drivers/infiniband/sw/siw/siw_verbs.c         |  7 ++++++-
> >  drivers/infiniband/sw/siw/siw_verbs.h         |  3 ++-
> >  include/rdma/ib_verbs.h                       |  3 +++
> >  include/uapi/rdma/ib_user_ioctl_cmds.h        |  1 +
> >  36 files changed, 144 insertions(+), 18 deletions(-)
> > 
> > diff --git a/drivers/infiniband/hw/hns/hns_roce_device.h b/drivers/infiniband/hw/hns/hns_roce_device.h
> > index 25f77b1fa773..78ee04a48a74 100644
> > --- a/drivers/infiniband/hw/hns/hns_roce_device.h
> > +++ b/drivers/infiniband/hw/hns/hns_roce_device.h
> > @@ -1219,6 +1219,7 @@ int hns_roce_dealloc_pd(struct ib_pd *pd, struct ib_udata *udata);
> >  struct ib_mr *hns_roce_get_dma_mr(struct ib_pd *pd, int acc);
> >  struct ib_mr *hns_roce_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,
> >  				   u64 virt_addr, int access_flags,
> > +				   struct ib_dmah *dmah,
> >  				   struct ib_udata *udata);
> >  struct ib_mr *hns_roce_rereg_user_mr(struct ib_mr *mr, int flags, u64 start,
> >  				     u64 length, u64 virt_addr,
> > diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c
> > index ebef93559225..03af842dd9d3 100644
> > --- a/drivers/infiniband/hw/hns/hns_roce_mr.c
> > +++ b/drivers/infiniband/hw/hns/hns_roce_mr.c
> > @@ -231,12 +231,16 @@ struct ib_mr *hns_roce_get_dma_mr(struct ib_pd *pd, int acc)
> >  
> >  struct ib_mr *hns_roce_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,
> >  				   u64 virt_addr, int access_flags,
> > +				   struct ib_dmah *dmah,
> >  				   struct ib_udata *udata)
> >  {
> >  	struct hns_roce_dev *hr_dev = to_hr_dev(pd->device);
> >  	struct hns_roce_mr *mr;
> >  	int ret;
> >  
> > +	if (dmah)
> > +		return ERR_PTR(-EOPNOTSUPP);
> > +
> 
> Could you change hns part as below? We have an error counter in the err_out label.

Of course, I will do it.

> 
> Thanks
> Junxian
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c
> index ebef93559225..e6ad6de97f10 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_mr.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_mr.c
> @@ -237,6 +237,11 @@ struct ib_mr *hns_roce_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,
>         struct hns_roce_mr *mr;
>         int ret;
> 
> +       if (dmah) {
> +               ret = -EOPNOTSUPP;
> +               goto err_out;
> +       }
> +
>         mr = kzalloc(sizeof(*mr), GFP_KERNEL);
>         if (!mr) {
>                 ret = -ENOMEM;
> 
> >  	mr = kzalloc(sizeof(*mr), GFP_KERNEL);
> >  	if (!mr) {
> >  		ret = -ENOMEM;