From: Stephen Hemminger <stephen@networkplumber.org>
To: Schneide <schneide@qti.qualcomm.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Reshma Pattan <reshma.pattan@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Zhirun Yan <yanzhirun_163@163.com>
Subject: Re: [PATCH v3] pcapng: allow any protocol link type for the interface block
Date: Tue, 8 Jul 2025 14:56:43 -0700 [thread overview]
Message-ID: <20250708145643.738b62e2@hermes.local> (raw)
In-Reply-To: <20250708210245.3967578-1-schneide@qti.qualcomm.com>
On Tue, 8 Jul 2025 15:02:45 -0600
Schneide <schneide@qti.qualcomm.com> wrote:
> From: Dylan Schneider <schneide@qti.qualcomm.com>
>
> Allow the user to specify protocol link type when creating pcapng files.
> This change is needed to specify the protocol type in the pcapng file,
> DLT_EN10MB specifies ethernet packets only. This will allow dissectors
> for other protocols to be used on files generated by pcapng.
>
> Includes a breaking change to rte_pcapng_add_interface to add link_type
> parameter. Existing calls to the function have been updated to pass
> DLT_EN10MB for the link type argument.
>
> Fixes: d1da6d0d04c7 ("pcapng: require per-interface information")
> Signed-off-by: Dylan Schneider <schneide@qti.qualcomm.com>
> Cc: stephen@networkplumber.org
> ---
> .mailmap | 1 +
> app/dumpcap/main.c | 4 +--
> app/test/test_pcapng.c | 8 +++---
> doc/guides/rel_notes/release_25_07.rst | 4 +++
Sorry too late for inclusion 25.07 release which is in last serious bugs only stage.
prev parent reply other threads:[~2025-07-08 21:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 17:16 [PATCH] pcapng: allow any protocol link type for the interface block Schneide
2025-05-29 19:31 ` Stephen Hemminger
2025-05-29 19:57 ` Stephen Hemminger
2025-06-05 23:02 ` [PATCH v2] " Schneide
2025-06-06 15:13 ` Stephen Hemminger
2025-06-06 21:52 ` Schneide
2025-06-08 22:16 ` Stephen Hemminger
2025-06-08 22:19 ` Stephen Hemminger
2025-06-08 22:23 ` Stephen Hemminger
2025-06-08 22:30 ` Stephen Hemminger
2025-06-08 22:34 ` Stephen Hemminger
2025-06-09 15:51 ` Dylan Schneider
2025-06-09 16:24 ` Stephen Hemminger
2025-06-16 14:29 ` Dylan Schneider
2025-06-24 15:15 ` Dylan Schneider
2025-06-09 21:19 ` Schneide
2025-06-16 18:05 ` Stephen Hemminger
2025-06-26 13:57 ` Stephen Hemminger
2025-06-27 16:05 ` Thomas Monjalon
2025-06-27 17:39 ` Thomas Monjalon
2025-06-27 17:46 ` Dylan Schneider
2025-06-27 18:27 ` Thomas Monjalon
2025-06-30 13:50 ` Dylan Schneider
2025-06-30 14:28 ` Thomas Monjalon
2025-07-02 19:30 ` Dylan Schneider
2025-07-03 13:27 ` Thomas Monjalon
2025-07-03 16:29 ` Dylan Schneider
2025-07-03 16:41 ` Thomas Monjalon
2025-07-08 21:02 ` [PATCH v3] " Schneide
2025-07-08 21:56 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708145643.738b62e2@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=reshma.pattan@intel.com \
--cc=schneide@qti.qualcomm.com \
--cc=thomas@monjalon.net \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.