From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68BD72E659; Tue, 8 Jul 2025 16:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992075; cv=none; b=R4G5s4XnRb0769GlAVrip0VBTFKQTR1Om04Lu1LwE+bAfyMg6Wuf7KJNPUtggEaBwO9KN94C+3Pt+J9eNHUtkzcAhHSCxtp4Kz0Vde9bXI6YY97ZC58o/3dtt39Um4xVBv8oD6jdMUc2rVJ69mI2/pUpmF1q7G9GAusIqus5fZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992075; c=relaxed/simple; bh=qMyNat2auF9nuvMTFJJhFiLFjEH5d3sP01x82p6cPEU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WMycuNEG3Jguln3b5ejCkAA/P8Cui/s3KmdJwmKDpZ7xyAsnEDoMLJJwobDJUuyLjXBJb7+Mrri8WhfL721L+pIzBSi8Pd1vh3+WWU+KqEFupn+DNV415Sdw+AgtwcapLLzDDABRFf68pUEwv/5sPzh6ulu18PbTKyQSQNrLT+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AFAxB+vF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AFAxB+vF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBA70C4CEED; Tue, 8 Jul 2025 16:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751992075; bh=qMyNat2auF9nuvMTFJJhFiLFjEH5d3sP01x82p6cPEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AFAxB+vFZiognvAncq+Pcqj2MlhZWAbfvexKu2ZmPIKzs6Nrq0wjJ+8ZYT5ZYyoGZ tf2UpPZdhLNlZZZ0+mdRx0tOLHJG7FL8BHhAq6LTbDEpy5rq3NncKz06KdY4Q9DeMf Sq/XEratcIQQKJIZ+IH9qy6bh4Hw7rS3bZIHdwpA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Fourier , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.1 20/81] scsi: qla2xxx: Fix DMA mapping test in qla24xx_get_port_database() Date: Tue, 8 Jul 2025 18:23:12 +0200 Message-ID: <20250708162225.569186447@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162224.795155912@linuxfoundation.org> References: <20250708162224.795155912@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Fourier [ Upstream commit c3b214719a87735d4f67333a8ef3c0e31a34837c ] dma_map_XXX() functions return as error values DMA_MAPPING_ERROR which is often ~0. The error value should be tested with dma_mapping_error() like it was done in qla26xx_dport_diagnostics(). Fixes: 818c7f87a177 ("scsi: qla2xxx: Add changes in preparation for vendor extended FDMI/RDP") Signed-off-by: Thomas Fourier Link: https://lore.kernel.org/r/20250617161115.39888-2-fourier.thomas@gmail.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 1fd9485985f2e..77b23d9dcb3c6 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -2147,7 +2147,7 @@ qla24xx_get_port_database(scsi_qla_host_t *vha, u16 nport_handle, pdb_dma = dma_map_single(&vha->hw->pdev->dev, pdb, sizeof(*pdb), DMA_FROM_DEVICE); - if (!pdb_dma) { + if (dma_mapping_error(&vha->hw->pdev->dev, pdb_dma)) { ql_log(ql_log_warn, vha, 0x1116, "Failed to map dma buffer.\n"); return QLA_MEMORY_ALLOC_FAILED; } -- 2.39.5