From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE4912E6121; Tue, 8 Jul 2025 16:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751993972; cv=none; b=CcA8xYQyHLWKKjG5UhZf+bpMIPGFyIQaJdh64Xa8EGgjO9Id6CF8av1dkXT03xkDxLyb92doa4p3qXsiXCZgpMivsJEuclodcOEVOn+776R4FyEIS997rHcwCVba+61eFLS4VI371PjBZIx75z9B3LIeCAyxszfJ/voHTdsYY68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751993972; c=relaxed/simple; bh=30SCST7c6vSylFD7K60EIPhunqpTsf9CBepA/5trSAY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dYfQi1uYUxrrsj5Yk8IB969Qst+kE+HLwcmQSJhO8qBmoRj8juRxkGq6FbqUe5Z5t8Euu+5V33iee0PSat77f6frLT725ZvsmF+T6WtEHiDL+m+OpthxF35DX5KHNFkR+B8Ch1NSGAWswzvnNnPz6YA43jU5B9zU/xOUzx2NckI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vJ/OTYu4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vJ/OTYu4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46FFCC4CEED; Tue, 8 Jul 2025 16:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751993972; bh=30SCST7c6vSylFD7K60EIPhunqpTsf9CBepA/5trSAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vJ/OTYu4K/gxMuGMdDdHRmOoYlEX8StxJkBYkgmwgq7V3q+2Z8a+WppkE21C0KHsM iuzZKNUl5vhvRC/xCgS2QxPqEE1Z9qdjjAprGumQ618KwRZIUx9RiU9n/DhhA+0G5x yy9GUA5AKIuN7WdjVfhhsTpiPMyUegppFJWx7Vmc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Zimmermann , dri-devel@lists.freedesktop.org, Patrik Jakobsson Subject: [PATCH 5.15 082/160] drm/udl: Unregister device before cleaning up on disconnect Date: Tue, 8 Jul 2025 18:21:59 +0200 Message-ID: <20250708162233.802969105@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162231.503362020@linuxfoundation.org> References: <20250708162231.503362020@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Zimmermann commit ff9cb6d2035c586ea7c8f1754d4409eec7a2d26d upstream. Disconnecting a DisplayLink device results in the following kernel error messages [ 93.041748] [drm:udl_urb_completion [udl]] *ERROR* udl_urb_completion - nonzero write bulk status received: -115 [ 93.055299] [drm:udl_submit_urb [udl]] *ERROR* usb_submit_urb error fffffffe [ 93.065363] [drm:udl_urb_completion [udl]] *ERROR* udl_urb_completion - nonzero write bulk status received: -115 [ 93.078207] [drm:udl_submit_urb [udl]] *ERROR* usb_submit_urb error fffffffe coming from KMS poll helpers. Shutting down poll helpers runs them one final time when the USB device is already gone. Run drm_dev_unplug() first in udl's USB disconnect handler. Udl's polling code already handles disconnects gracefully if the device has been marked as unplugged. Signed-off-by: Thomas Zimmermann Fixes: b1a981bd5576 ("drm/udl: drop drm_driver.release hook") Cc: dri-devel@lists.freedesktop.org Cc: # v5.8+ Reviewed-by: Patrik Jakobsson Link: https://patchwork.freedesktop.org/patch/msgid/20250303145604.62962-2-tzimmermann@suse.de Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/udl/udl_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/udl/udl_drv.c +++ b/drivers/gpu/drm/udl/udl_drv.c @@ -110,9 +110,9 @@ static void udl_usb_disconnect(struct us { struct drm_device *dev = usb_get_intfdata(interface); + drm_dev_unplug(dev); drm_kms_helper_poll_fini(dev); udl_drop_usb(dev); - drm_dev_unplug(dev); } /*