From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3D572E717D; Tue, 8 Jul 2025 17:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751994123; cv=none; b=s3nL8EgeScY/34absV6s4yfpJlNrdubFklOGihxK0ZegYfQyDvzppypeOsz1Dn/QqRcXKg3v9+VFNbHKSYhAo7AuXRNZrHu+mjHBELjPZoSiaiyCKuOETQvfxmIgWDq32re6qwk6STxf4DKr2mjZRE9+lXHsHs5Pbo1RQmx6bnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751994123; c=relaxed/simple; bh=tVHV1C5PejrPosj9dd3z/IlO5jkn5ZQoChvleIHFa4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NhxlkQeAjS7qAFv3zsL1aFLvuN6wJzXd16zK0YuB05dcaKwanjC7nmdCW77AkBd+opCt6Ip0jV4yp1hxHPg5cKbQ1uN0Lf2re6BLOD1JGE+DatxSNvpfIS0q1RyF9m1kMIJKBrIYwJAe2P5ze/0G66U0LGTLHxi27kG/1bZL4Os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=t9OS4MC1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="t9OS4MC1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBE18C4CEED; Tue, 8 Jul 2025 17:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751994122; bh=tVHV1C5PejrPosj9dd3z/IlO5jkn5ZQoChvleIHFa4I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t9OS4MC1vWfBuAgmgQnS/ogrufSmdx5bjmLA5j1uhaBHAQKOqcS60rhNpZMv9s6dc 5TD1iT1dkwEFcX5Zl4ETe4+/kMUb2pXOsayzGCoTPYv2Gz3p5i0pCFPEyldtbABL7k dLelUmxt9NkGROrVAi3E4savv7DBiEx+90ttCgeg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maurizio Lombardi , Mike Christie , John Meneghini , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.15 131/160] scsi: target: Fix NULL pointer dereference in core_scsi3_decode_spec_i_port() Date: Tue, 8 Jul 2025 18:22:48 +0200 Message-ID: <20250708162235.031464935@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162231.503362020@linuxfoundation.org> References: <20250708162231.503362020@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maurizio Lombardi [ Upstream commit d8ab68bdb294b09a761e967dad374f2965e1913f ] The function core_scsi3_decode_spec_i_port(), in its error code path, unconditionally calls core_scsi3_lunacl_undepend_item() passing the dest_se_deve pointer, which may be NULL. This can lead to a NULL pointer dereference if dest_se_deve remains unset. SPC-3 PR SPEC_I_PT: Unable to locate dest_tpg Unable to handle kernel paging request at virtual address dfff800000000012 Call trace: core_scsi3_lunacl_undepend_item+0x2c/0xf0 [target_core_mod] (P) core_scsi3_decode_spec_i_port+0x120c/0x1c30 [target_core_mod] core_scsi3_emulate_pro_register+0x6b8/0xcd8 [target_core_mod] target_scsi3_emulate_pr_out+0x56c/0x840 [target_core_mod] Fix this by adding a NULL check before calling core_scsi3_lunacl_undepend_item() Signed-off-by: Maurizio Lombardi Link: https://lore.kernel.org/r/20250612101556.24829-1-mlombard@redhat.com Reviewed-by: Mike Christie Reviewed-by: John Meneghini Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_pr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c index 3829b61b56c12..f4a797d3c5734 100644 --- a/drivers/target/target_core_pr.c +++ b/drivers/target/target_core_pr.c @@ -1852,7 +1852,9 @@ core_scsi3_decode_spec_i_port( } kmem_cache_free(t10_pr_reg_cache, dest_pr_reg); - core_scsi3_lunacl_undepend_item(dest_se_deve); + + if (dest_se_deve) + core_scsi3_lunacl_undepend_item(dest_se_deve); if (is_local) continue; -- 2.39.5