From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 416CE23A98D; Tue, 8 Jul 2025 16:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992750; cv=none; b=Uzv3UPYoQxAqq4622t71RBGcziA8vob+T+yls/2lUm7wfOSxq9PzCYFlKSrxMBglM/3s1GtT+8Z/+VC+wFk3ReJ50CpNG36Fwo0Y+zjZ+z9h3MG/jnQjIXE0JqYj3P7OxNOfJq+hisQFn0zd2W3fXUQd0auoFl5SA7zYiLCrsQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992750; c=relaxed/simple; bh=yFoS1jlj16q73m15W8nLkKgiu3yfrPrSqa0lSY8kYDc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WQAopcAXu+YwIaXXQr+8DAnz9Li2QkShL2xSzmUF3FEBC8e6kWeQyy8uzdk7QwuYr1JK3jMxrsTcL6bhU+uyfYAUMEd/JZoqmzIDSVdpa7PG4eZrfORauctZm7p3Ndff+E6mxS4s3A0D5bAg7hE6tq/7uN33ju2GalDz1080pl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ca9c1PK8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ca9c1PK8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE600C4CEED; Tue, 8 Jul 2025 16:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751992750; bh=yFoS1jlj16q73m15W8nLkKgiu3yfrPrSqa0lSY8kYDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ca9c1PK8r6YBF4PC0rP3PTZ6PcexnsbYUfKvWg+0gdB+QSAkf8Lp+i6ddpkDyGUgo LvlctiODtJztVxrRA9FOIHBJ2IcYAhwVGALg0AhQp1llVsxZS/IK7s3Mc8SPGJEv/h hTJ4q0PGQyQVsvIBVsWQcj3j0/UjVPN54h5MuiFs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Fourier , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.12 037/232] scsi: qla2xxx: Fix DMA mapping test in qla24xx_get_port_database() Date: Tue, 8 Jul 2025 18:20:33 +0200 Message-ID: <20250708162242.400959986@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162241.426806072@linuxfoundation.org> References: <20250708162241.426806072@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Fourier [ Upstream commit c3b214719a87735d4f67333a8ef3c0e31a34837c ] dma_map_XXX() functions return as error values DMA_MAPPING_ERROR which is often ~0. The error value should be tested with dma_mapping_error() like it was done in qla26xx_dport_diagnostics(). Fixes: 818c7f87a177 ("scsi: qla2xxx: Add changes in preparation for vendor extended FDMI/RDP") Signed-off-by: Thomas Fourier Link: https://lore.kernel.org/r/20250617161115.39888-2-fourier.thomas@gmail.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 0cd6f3e148824..13b6cb1b93acd 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -2147,7 +2147,7 @@ qla24xx_get_port_database(scsi_qla_host_t *vha, u16 nport_handle, pdb_dma = dma_map_single(&vha->hw->pdev->dev, pdb, sizeof(*pdb), DMA_FROM_DEVICE); - if (!pdb_dma) { + if (dma_mapping_error(&vha->hw->pdev->dev, pdb_dma)) { ql_log(ql_log_warn, vha, 0x1116, "Failed to map dma buffer.\n"); return QLA_MEMORY_ALLOC_FAILED; } -- 2.39.5