From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48C9F2E041C; Tue, 8 Jul 2025 16:40:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992802; cv=none; b=KSuqHIws3Ojq0Er5Cya2azThNtODqvx6dM1izkW8CiYRxts2aBW9u9zeMTKzGW2bfWrhoWAgVUpfQ7E4p7MDXd13PmuMRThCcC3k+G2DPtBA4FQvwM/KjRQA1zCDLCiz63hoUmDPr1pdsHi5op55l5YlDusmRv/B28ZDl8sIS14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992802; c=relaxed/simple; bh=7KRki01a4UABBUTRxv8mNCVL4JlwHR5boIS/sPfrCSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K2NTkbmikLq+huqEW6gSQZrZix22pDdaThEFcLptt2FLsVDc2JQzuil+8Utj+N8InoX6TvQJwc16siOzOW1VnuKpKNDXgQ94+ctrWUUL1pjtJXPj0eaBQq+mD23RwyO8B9KF6TMVlAg++yfsKZq67hQcfxSGgT1p1gNEDdnIjKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=p02itcJy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="p02itcJy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67CF7C4CEF6; Tue, 8 Jul 2025 16:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751992801; bh=7KRki01a4UABBUTRxv8mNCVL4JlwHR5boIS/sPfrCSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p02itcJyMQGqJwKrvqA1t+IIeAF7hWO7Lj65mMCMRIC/Pfnq/QV12nDR+5G4y2PL3 pQK1YsvLu6941WYJq3W4pcQbXS01ZeCRYLkgtNm7kQZIeTW71aV1l/kEXy0dCyRXde iZjBqKRBnkNFKgoDdEasjuBXqIbqj12PWv4yJwyM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Dan Carpenter , Ido Schimmel , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 085/232] lib: test_objagg: Set error message in check_expect_hints_stats() Date: Tue, 8 Jul 2025 18:21:21 +0200 Message-ID: <20250708162243.673640360@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162241.426806072@linuxfoundation.org> References: <20250708162241.426806072@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit e6ed134a4ef592fe1fd0cafac9683813b3c8f3e8 ] Smatch complains that the error message isn't set in the caller: lib/test_objagg.c:923 test_hints_case2() error: uninitialized symbol 'errmsg'. This static checker warning only showed up after a recent refactoring but the bug dates back to when the code was originally added. This likely doesn't affect anything in real life. Reported-by: kernel test robot Closes: https://lore.kernel.org/r/202506281403.DsuyHFTZ-lkp@intel.com/ Fixes: 0a020d416d0a ("lib: introduce initial implementation of object aggregation manager") Signed-off-by: Dan Carpenter Reviewed-by: Ido Schimmel Reviewed-by: Simon Horman Link: https://patch.msgid.link/8548f423-2e3b-4bb7-b816-5041de2762aa@sabinyo.mountain Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- lib/test_objagg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/test_objagg.c b/lib/test_objagg.c index d34df4306b874..222b39fc2629e 100644 --- a/lib/test_objagg.c +++ b/lib/test_objagg.c @@ -899,8 +899,10 @@ static int check_expect_hints_stats(struct objagg_hints *objagg_hints, int err; stats = objagg_hints_stats_get(objagg_hints); - if (IS_ERR(stats)) + if (IS_ERR(stats)) { + *errmsg = "objagg_hints_stats_get() failed."; return PTR_ERR(stats); + } err = __check_expect_stats(stats, expect_stats, errmsg); objagg_stats_put(stats); return err; -- 2.39.5