From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828362F37; Tue, 8 Jul 2025 16:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751993230; cv=none; b=Y/hybQwaN9eb7u1poboVw8TewBFqY9uQQ6wG4zJNCeaQokEECyKUmQUppo/3R/t7DzRuAG74Rco1V8gsGzNsN8ebLZ/4T4uMim4oBkNIG8UW+RXcBi7FJcESb0VPR/PGDqbfUKIXnChqhcr9p/ZyChSla2yeDugd+fztNFeQU0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751993230; c=relaxed/simple; bh=l5MENnbanigspXZ5CSPEFCNNDxsXGPexwqMWaJijHWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GFhJlzj8IxXlTBjp3jEvyVdD8eMAPH6dTA6zYnMUV3dlwmrP1nR8pKsO242ZLJpSQx3n8dMj8LzbBrcE1Ow3Mc796i/jLuzH4CHPyG3vTp+avut0cyUHCj5MYO8VQ+eYDM/6882x8mrJwbCtCJXDOe0JqrAfPP26E+8g3iMpYPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MUtVqf35; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MUtVqf35" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D7AFC4CEED; Tue, 8 Jul 2025 16:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751993230; bh=l5MENnbanigspXZ5CSPEFCNNDxsXGPexwqMWaJijHWE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MUtVqf35gr4WORQNiWyllL0eitrSBeCnKErP7UZ+xJK262aeo0PLiYrmU/0JG5IIk svX1hEmJtgYwgkrP59eDrK1+3piH1+bmpy+4hN9eQF+ayg4mg3vbnxuI2rjfyneKNq YR5c71NogTYeOC/VRKngHjH5Fg2+YjF0bcFFhFB4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Mathias Nyman Subject: [PATCH 6.12 202/232] xhci: dbctty: disable ECHO flag by default Date: Tue, 8 Jul 2025 18:23:18 +0200 Message-ID: <20250708162246.722277087@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162241.426806072@linuxfoundation.org> References: <20250708162241.426806072@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Łukasz Bartosik commit 2b857d69a5e116150639a0c6c39c86cc329939ee upstream. When /dev/ttyDBC0 device is created then by default ECHO flag is set for the terminal device. However if data arrives from a peer before application using /dev/ttyDBC0 applies its set of terminal flags then the arriving data will be echoed which might not be desired behavior. Fixes: 4521f1613940 ("xhci: dbctty: split dbc tty driver registration and unregistration functions.") Cc: stable Signed-off-by: Łukasz Bartosik Signed-off-by: Mathias Nyman Link: https://lore.kernel.org/stable/20250610111802.18742-1-ukaszb%40chromium.org Link: https://lore.kernel.org/r/20250627144127.3889714-4-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/xhci-dbgtty.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/host/xhci-dbgtty.c +++ b/drivers/usb/host/xhci-dbgtty.c @@ -585,6 +585,7 @@ int dbc_tty_init(void) dbc_tty_driver->type = TTY_DRIVER_TYPE_SERIAL; dbc_tty_driver->subtype = SERIAL_TYPE_NORMAL; dbc_tty_driver->init_termios = tty_std_termios; + dbc_tty_driver->init_termios.c_lflag &= ~ECHO; dbc_tty_driver->init_termios.c_cflag = B9600 | CS8 | CREAD | HUPCL | CLOCAL; dbc_tty_driver->init_termios.c_ispeed = 9600;