From: Rob Herring <robh@kernel.org>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Philipp Zabel <p.zabel@pengutronix.de>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/9] dt-bindings: watchdog: renesas,wdt: Add support for RZ/T2H and RZ/N2H
Date: Tue, 8 Jul 2025 15:18:06 -0500 [thread overview]
Message-ID: <20250708201806.GA897559-robh@kernel.org> (raw)
In-Reply-To: <20250707200111.329663-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
On Mon, Jul 07, 2025 at 09:01:03PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Extend the Renesas WDT device tree bindings to support the watchdog timer
> found on the RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs.
>
> The RZ/T2H WDT is mostly compatible with the one found on the RZ/V2H(P),
> but includes an additional register and differs in the clock division
> ratio settings for the WDTCR[CKS] field. To reflect these differences,
> introduce a new compatible string, "renesas,r9a09g077-wdt".
>
> The binding schema is updated accordingly. On RZ/T2H, the WDT does not
> require the "resets" property. It also requires two register regions and
> the presence of a "power-domains" property. The "clock-names" property is
> limited to a single entry, "pclk", for this SoC.
>
> The RZ/N2H SoC uses the same WDT IP as the RZ/T2H. It is supported by
> using "renesas,r9a09g087-wdt" as the primary compatible string, with
> "renesas,r9a09g077-wdt" listed as a fallback to describe the shared
> hardware features.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> .../bindings/watchdog/renesas,wdt.yaml | 37 +++++++++++++++++--
> 1 file changed, 34 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> index 78874b90c88c..ce439a401c12 100644
> --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> @@ -81,10 +81,17 @@ properties:
> - renesas,r9a09g056-wdt # RZ/V2N
> - const: renesas,r9a09g057-wdt # RZ/V2H(P)
>
> - - const: renesas,r9a09g057-wdt # RZ/V2H(P)
> + - enum:
> + - renesas,r9a09g057-wdt # RZ/V2H(P)
> + - renesas,r9a09g077-wdt # RZ/T2H
> +
> + - items:
> + - const: renesas,r9a09g087-wdt # RZ/N2H
> + - const: renesas,r9a09g077-wdt # RZ/T2H
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> interrupts:
> minItems: 1
> @@ -132,6 +139,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - renesas,r9a09g077-wdt
> - renesas,rza-wdt
> - renesas,rzn1-wdt
> then:
> @@ -183,7 +191,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: renesas,r9a09g057-wdt
> + enum:
> + - renesas,r9a09g057-wdt
> + - renesas,r9a09g077-wdt
> then:
> properties:
> interrupts: false
> @@ -192,6 +202,27 @@ allOf:
> required:
> - interrupts
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a09g077-wdt
> + then:
> + properties:
> + resets: false
> + clock-names:
> + items:
> + - const: pclk
Just 'maxItems: 1' as pclk is already the defined name.
With that,
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2025-07-08 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 20:01 [PATCH 0/9] Add watchdog driver support for RZ/T2H and RZ/N2H SoCs Prabhakar
2025-07-07 20:01 ` [PATCH 1/9] dt-bindings: watchdog: renesas,wdt: Add support for RZ/T2H and RZ/N2H Prabhakar
2025-07-08 20:18 ` Rob Herring [this message]
2025-07-07 20:01 ` [PATCH 2/9] watchdog: rzv2h_wdt: Obtain clock-divider ranges from OF match data Prabhakar
2025-07-07 20:01 ` [PATCH 3/9] watchdog: rzv2h_wdt: Obtain CKS divider via OF data Prabhakar
2025-07-07 20:01 ` [PATCH 4/9] watchdog: rzv2h_wdt: Make "oscclk" an optional clock Prabhakar
2025-07-07 20:01 ` [PATCH 5/9] watchdog: rzv2h_wdt: Add support for configurable count clock source Prabhakar
2025-07-07 20:01 ` [PATCH 6/9] watchdog: rzv2h_wdt: Make reset controller optional Prabhakar
2025-07-07 20:01 ` [PATCH 7/9] watchdog: rzv2h: Set min_timeout based on max_hw_heartbeat_ms Prabhakar
2025-07-07 20:01 ` [PATCH 8/9] watchdog: rzv2h: Add support for RZ/T2H Prabhakar
2025-07-07 20:01 ` [PATCH 9/9] watchdog: rzv2h_wdt: Improve error strings and add newlines Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708201806.GA897559-robh@kernel.org \
--to=robh@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.