Re: [PATCH] tools: bootconfig: Regex brackets need escape

[Masami Hiramatsu (Google) <mhiramat@kernel.org>]

Hi Bhaskar,

On Tue,  8 Jul 2025 14:46:08 +0530
Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:

> It was showing malformed syntax colors below those lines,escaping the posix
> class brackets bring back the syntatic reference back.
> 
> Oh, malformed syntax colors means,(in a editor,in this case Vim, where syntax
> highlight is on). In essence, it might complain while running the script.

Hmm, that means your editor's parser's bug, right?

> 
> Hence, this trivialities.
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  tools/bootconfig/test-bootconfig.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/bootconfig/test-bootconfig.sh b/tools/bootconfig/test-bootconfig.sh
> index a2c484c243f5..211409539737 100755
> --- a/tools/bootconfig/test-bootconfig.sh
> +++ b/tools/bootconfig/test-bootconfig.sh
> @@ -167,8 +167,8 @@ echo > $INITRD
> 
>  xpass $BOOTCONF -a $TEMPCONF $INITRD
>  $BOOTCONF $INITRD > $OUTFILE
> -xfail grep -q val[[:space:]] $OUTFILE
> -xpass grep -q val2[[:space:]] $OUTFILE
> +xfail grep -q val\[\[:space:\]\] $OUTFILE
> +xpass grep -q val2\[\[:space:\]\] $OUTFILE

Can you escape it by quotations? In that case, it is acceptable
as a cleanup. e.g. 'val[[:space:]]'.

Thank you,


> 
>  echo "=== expected failure cases ==="
>  for i in samples/bad-* ; do
> --
> 2.49.0
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>