From: Simon Horman <horms@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, michal.kubiak@intel.com,
mengyuanlou@net-swift.com, duanqiangwen@net-swift.com,
stable@vger.kernel.org
Subject: Re: [PATCH net 2/3] net: libwx: fix the using of Rx buffer DMA
Date: Wed, 9 Jul 2025 12:43:13 +0100 [thread overview]
Message-ID: <20250709114313.GV452973@horms.kernel.org> (raw)
In-Reply-To: <20250709064025.19436-3-jiawenwu@trustnetic.com>
On Wed, Jul 09, 2025 at 02:40:24PM +0800, Jiawen Wu wrote:
> The wx_rx_buffer structure contained two DMA address fields: 'dma' and
> 'page_dma'. However, only 'page_dma' was actually initialized and used
> to program the Rx descriptor. But 'dma' was uninitialized and used in
> some paths.
>
> This could lead to undefined behavior, including DMA errors or
> use-after-free, if the uninitialized 'dma' was used. Althrough such
> error has not yet occurred, it is worth fixing in the code.
>
> Fixes: 3c47e8ae113a ("net: libwx: Support to receive packets in NAPI")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-07-09 11:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 6:40 [PATCH net 0/3] Fix Rx fatal errors Jiawen Wu
2025-07-09 6:40 ` [PATCH net 1/3] net: libwx: remove duplicate page_pool_put_full_page() Jiawen Wu
2025-07-09 11:47 ` Simon Horman
2025-07-09 6:40 ` [PATCH net 2/3] net: libwx: fix the using of Rx buffer DMA Jiawen Wu
2025-07-09 11:43 ` Simon Horman [this message]
2025-07-09 6:40 ` [PATCH net 3/3] net: libwx: properly reset Rx ring descriptor Jiawen Wu
2025-07-09 11:43 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709114313.GV452973@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.