From: Jakub Kicinski <kuba@kernel.org>
To: Nimrod Oren <noren@nvidia.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
Gal Pressman <gal@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>
Subject: Re: [PATCH net] selftests: drv-net: rss_ctx: Add short delay between per-context traffic checks
Date: Wed, 9 Jul 2025 13:18:00 -0700 [thread overview]
Message-ID: <20250709131800.580fde62@kernel.org> (raw)
In-Reply-To: <6b8c512d-ced5-4116-9dde-fee081fda850@nvidia.com>
On Wed, 9 Jul 2025 20:10:14 +0300 Nimrod Oren wrote:
> On 02/07/2025 3:23, Jakub Kicinski wrote:
> > On Sun, 29 Jun 2025 14:18:12 +0300 Nimrod Oren wrote:
> >> A few packets may still be sent and received during the termination of
> >> the iperf processes. These late packets cause failures when they arrive
> >> on queues expected to be empty.
> >>
> >> Add a one second delay between repeated _send_traffic_check() calls in
> >> rss_ctx tests to ensure such packets are processed before the next
> >> traffic checks are performed.
> >
> > Sprinklings sleeps should be last resort. Is there a way to wait for
> > iperf to shut down cleanly, or wait for the socket to be closed fully?
> > Like wait_port_listen() ?
>
> The socket may end up in TIME_WAIT state, so waiting for it to be fully
> closed can take ~2 mins.
TIME_WAIT is as good as CLOSED for our purposes. Once we got a FIN
the chances of more traffic should be minuscule.
prev parent reply other threads:[~2025-07-09 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 11:18 [PATCH net] selftests: drv-net: rss_ctx: Add short delay between per-context traffic checks Nimrod Oren
2025-07-02 0:23 ` Jakub Kicinski
2025-07-09 17:10 ` Nimrod Oren
2025-07-09 20:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709131800.580fde62@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.