From: Simon Horman <horms@kernel.org>
To: Yun Lu <luyun_611@163.com>
Cc: willemdebruijn.kernel@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] af_packet: fix soft lockup issue caused by tpacket_snd()
Date: Wed, 9 Jul 2025 19:14:34 +0100 [thread overview]
Message-ID: <20250709181434.GH721198@horms.kernel.org> (raw)
In-Reply-To: <20250709095653.62469-3-luyun_611@163.com>
On Wed, Jul 09, 2025 at 05:56:53PM +0800, Yun Lu wrote:
...
> @@ -2943,14 +2953,7 @@ static int tpacket_snd(struct packet_sock *po, struct msghdr *msg)
> }
> packet_increment_head(&po->tx_ring);
> len_sum += tp_len;
> - } while (likely((ph != NULL) ||
> - /* Note: packet_read_pending() might be slow if we have
> - * to call it as it's per_cpu variable, but in fast-path
> - * we already short-circuit the loop with the first
> - * condition, and luckily don't have to go that path
> - * anyway.
> - */
> - (need_wait && packet_read_pending(&po->tx_ring))));
> + } while (likely(ph != NULL))
A semicolon is needed at the end of the line above.
>
> err = len_sum;
> goto out_put;
--
pw-bot: changes-requested
next prev parent reply other threads:[~2025-07-09 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 9:56 [PATCH v3 0/2] fix two issues on tpacket_snd() Yun Lu
2025-07-09 9:56 ` [PATCH v3 1/2] af_packet: fix the SO_SNDTIMEO constraint not effective on tpacked_snd() Yun Lu
2025-07-09 12:41 ` Eric Dumazet
2025-07-09 17:06 ` Willem de Bruijn
2025-07-09 18:15 ` Simon Horman
2025-07-09 9:56 ` [PATCH v3 2/2] af_packet: fix soft lockup issue caused by tpacket_snd() Yun Lu
2025-07-09 12:44 ` Eric Dumazet
2025-07-10 2:18 ` luyun
2025-07-09 18:14 ` Simon Horman [this message]
2025-07-10 2:20 ` luyun
2025-07-09 21:14 ` Willem de Bruijn
2025-07-10 2:36 ` luyun
2025-07-10 7:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709181434.GH721198@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luyun_611@163.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.