All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] net: netdevsim: Support setting dev->perm_addr on port creation
Date: Wed, 9 Jul 2025 19:20:07 -0700	[thread overview]
Message-ID: <20250709192007.145b8919@kernel.org> (raw)
In-Reply-To: <20250706-netdevsim-perm_addr-v3-1-88123e2b2027@redhat.com>

On Sun, 06 Jul 2025 16:45:31 +0200 Toke Høiland-Jørgensen wrote:
> +	ret = sscanf(buf, "%u %hhx:%hhx:%hhx:%hhx:%hhx:%hhx", &port_index,
> +		     &eth_addr[0], &eth_addr[1], &eth_addr[2], &eth_addr[3],
> +		     &eth_addr[4], &eth_addr[5]);
> +	switch (ret) {
> +	case 7:
> +		addr_set = true;
> +		fallthrough;

Feels like we should run is_valid_ether_addr() over the address.
-- 
pw-bot: cr

  parent reply	other threads:[~2025-07-10  2:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-06 14:45 [PATCH net-next v3 0/2] netdevsim: support setting a permanent address Toke Høiland-Jørgensen
2025-07-06 14:45 ` [PATCH net-next v3 1/2] net: netdevsim: Support setting dev->perm_addr on port creation Toke Høiland-Jørgensen
2025-07-07 19:03   ` Simon Horman
2025-07-10  2:20   ` Jakub Kicinski [this message]
2025-07-06 14:45 ` [PATCH net-next v3 2/2] selftests: net: add netdev-l2addr.sh for testing L2 address functionality Toke Høiland-Jørgensen
2025-07-07 19:03   ` Simon Horman
2025-07-10  2:17   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250709192007.145b8919@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.