From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeed@kernel.org>, Gal Pressman <gal@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/5] net/mlx5e: Replace recursive VLAN push handling with an iterative loop
Date: Wed, 9 Jul 2025 19:47:17 -0700 [thread overview]
Message-ID: <20250709194717.101a7a22@kernel.org> (raw)
In-Reply-To: <1752009387-13300-4-git-send-email-tariqt@nvidia.com>
On Wed, 9 Jul 2025 00:16:25 +0300 Tariq Toukan wrote:
> + rcu_read_lock();
> + *out_dev = dev_get_by_index_rcu(dev_net(vlan_dev),
> + dev_get_iflink(vlan_dev));
> + rcu_read_unlock();
> + if (!*out_dev)
> + return -ENODEV;
> + } while (is_vlan_dev(*out_dev));
Would be good adding a comment here to explain why this odd rcu lock
/ lookup / rcu unlock / keep using the return value outside of rcu
protection - code flow is correct :S
next prev parent reply other threads:[~2025-07-10 2:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 21:16 [PATCH net-next 0/5] net/mlx5: misc changes 2025-07-09 Tariq Toukan
2025-07-08 21:16 ` [PATCH net-next 1/5] net/mlx5e: Remove unused VLAN insertion logic in TX path Tariq Toukan
2025-07-09 17:23 ` Simon Horman
2025-07-08 21:16 ` [PATCH net-next 2/5] net/mlx5e: CT: extract a memcmp from a spinlock section Tariq Toukan
2025-07-09 17:24 ` Simon Horman
2025-07-08 21:16 ` [PATCH net-next 3/5] net/mlx5e: Replace recursive VLAN push handling with an iterative loop Tariq Toukan
2025-07-09 17:24 ` Simon Horman
2025-07-10 2:47 ` Jakub Kicinski [this message]
2025-07-08 21:16 ` [PATCH net-next 4/5] net/mlx5: Warn when write combining is not supported Tariq Toukan
2025-07-09 17:24 ` Simon Horman
2025-07-08 21:16 ` [PATCH net-next 5/5] net/mlx5e: RX, Remove unnecessary RQT redirects Tariq Toukan
2025-07-09 17:24 ` Simon Horman
2025-07-10 3:00 ` [PATCH net-next 0/5] net/mlx5: misc changes 2025-07-09 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709194717.101a7a22@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.