All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: stable@vger.kernel.org, luca.ceresoli@bootlin.com,
	olivier.benjamin@bootlin.com, thomas.petazzoni@bootlin.com
Subject: Re: Backport perf makefile fix to linux-6.6.y
Date: Wed, 9 Jul 2025 15:41:44 +0200	[thread overview]
Message-ID: <2025070955-discover-tree-644c@gregkh> (raw)
In-Reply-To: <DB7KBHKKHY3R.OG18BA9316QV@bootlin.com>

On Wed, Jul 09, 2025 at 03:35:34PM +0200, Alexis Lothoré wrote:
> On Wed Jul 9, 2025 at 12:39 PM CEST, Greg KH wrote:
> > On Wed, Jul 09, 2025 at 12:19:01PM +0200, Alexis Lothoré wrote:
> >> Hello stable team,
> >> 
> >> could you please backport commit 440cf77625e3 ("perf: build: Setup
> >> PKG_CONFIG_LIBDIR for cross compilation") to linux-6.6.y ?
> >> 
> >> Its absence prevents some people from building the perf tool in cross-compile
> >> environment with this kernel. The patch applies cleanly on linux-6.6.y
> >
> > Is this a regression from older kernels that was broken in 6.6.y, or is
> > this a new feature?  If a new feature, why not just use perf from a
> > newer kernel version instead?
> 
> I manage to build perf with a 5.15.x kernel, while I can't in 6.6 (with the
> same parameters), so yes, I would call it a regression.
> To clarify my wording, when I say that missing this patch prevents from
> building perf, it actually _breaks_ perf build, when trying to build it
> with libtraceevent support:
>  
> In file included from /home/alexis/src/buildroot/output/build/linux-6.6.94/tools/perf//util/session.h:5,
>                  from builtin-c2c.c:29:
> /home/alexis/src/buildroot/output/build/linux-6.6.94/tools/perf//util/trace-event.h:149:62: error: operator '&&' has no right operand
>   149 | #if defined(LIBTRACEEVENT_VERSION) &&  LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)

Fair enough, thanks!

Note, I never can seem to build perf in the "older" LTS kernels, so I'm
amazed it works at all for you :)

I'll queue this up after this round of releases goes out later this
week.

greg k-h

      reply	other threads:[~2025-07-09 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09 10:19 Backport perf makefile fix to linux-6.6.y Alexis Lothoré
2025-07-09 10:39 ` Greg KH
2025-07-09 13:35   ` Alexis Lothoré
2025-07-09 13:41     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025070955-discover-tree-644c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexis.lothore@bootlin.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=olivier.benjamin@bootlin.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.