All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tao Chen <chen.dylane@linux.dev>
To: daniel@iogearbox.net, razor@blackwall.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, ast@kernel.org, andrii@kernel.org,
	martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
	yonghong.song@linux.dev, john.fastabend@gmail.com,
	kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
	jolsa@kernel.org, mattbobrowski@google.com, rostedt@goodmis.org,
	mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
	horms@kernel.org, willemb@google.com, jakub@cloudflare.com,
	pablo@netfilter.org, kadlec@netfilter.org, hawk@kernel.org
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	Tao Chen <chen.dylane@linux.dev>
Subject: [PATCH bpf-next v4 0/7] Move attach_type into bpf_link
Date: Thu, 10 Jul 2025 11:20:31 +0800	[thread overview]
Message-ID: <20250710032038.888700-1-chen.dylane@linux.dev> (raw)

Andrii suggested moving the attach_type into bpf_link, the previous discussion
is as follows:
https://lore.kernel.org/bpf/CAEf4BzY7TZRjxpCJM-+LYgEqe23YFj5Uv3isb7gat2-HU4OSng@mail.gmail.com

patch1 add attach_type in bpf_link, and pass it to bpf_link_init, which
will init the attach_type field.

patch2-7 remove the attach_type in struct bpf_xx_link, update the info
with bpf_link attach_type.

There are some functions finally call bpf_link_init but do not have bpf_attr
from user or do not need to init attach_type from user like bpf_raw_tracepoint_open,
now use prog->expected_attach_type to init attach_type.

bpf_struct_ops_map_update_elem
bpf_raw_tracepoint_open
bpf_struct_ops_test_run

Feedback of any kind is welcome, thanks.

Tao Chen (7):
  bpf: Add attach_type in bpf_link
  bpf: Remove attach_type in bpf_cgroup_link
  bpf: Remove attach_type in sockmap_link
  bpf: Remove location field in tcx_link
  bpf: Remove attach_type in bpf_netns_link
  bpf: Remove attach_type in bpf_tracing_link
  netkit: Remove location field in netkit_link

 drivers/net/netkit.c           | 10 ++++-----
 include/linux/bpf-cgroup.h     |  1 -
 include/linux/bpf.h            | 29 ++++++++++++++----------
 include/net/tcx.h              |  1 -
 kernel/bpf/bpf_iter.c          |  3 ++-
 kernel/bpf/bpf_struct_ops.c    |  5 +++--
 kernel/bpf/cgroup.c            | 17 +++++++--------
 kernel/bpf/net_namespace.c     | 10 ++++-----
 kernel/bpf/syscall.c           | 40 ++++++++++++++++++++--------------
 kernel/bpf/tcx.c               | 16 +++++++-------
 kernel/bpf/trampoline.c        | 10 +++++----
 kernel/trace/bpf_trace.c       |  4 ++--
 net/bpf/bpf_dummy_struct_ops.c |  3 ++-
 net/core/dev.c                 |  3 ++-
 net/core/sock_map.c            | 13 +++++------
 net/netfilter/nf_bpf_link.c    |  3 ++-
 16 files changed, 90 insertions(+), 78 deletions(-)

Change list:
 v3 -> v4:
  - move netns_type field to the end in bpf_netns_link to fill the byte
    hole.(Jakub)
  - the series reviewed-by Jakub
  - patch1,2,3,4,7 acked-by Daniel
  - patch7 acked-by Nikolay
  - change the patch0 name to be consistent with the v1 version, sorry for that
    the name is the same as patch1 in v2 and v3.
 v3: https://lore.kernel.org/bpf/20250709030802.850175-1-chen.dylane@linux.dev

 v2 -> v3:
  - move sleepable field to the end in bpf_link to fill the byte hole.(Jiri)
  - Acked from Jiri
 v2: https://lore.kernel.org/bpf/20250708082228.824766-1-chen.dylane@linux.dev

 v1 -> v2:
  - fix build error.(Jiri)
 v1: https://lore.kernel.org/bpf/20250707153916.802802-1-chen.dylane@linux.dev
-- 
2.48.1


             reply	other threads:[~2025-07-10  3:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10  3:20 Tao Chen [this message]
2025-07-10  3:20 ` [PATCH bpf-next v4 1/7] bpf: Add attach_type in bpf_link Tao Chen
2025-07-11 17:50   ` Andrii Nakryiko
2025-07-10  3:20 ` [PATCH bpf-next v4 2/7] bpf: Remove attach_type in bpf_cgroup_link Tao Chen
2025-07-10  3:20 ` [PATCH bpf-next v4 3/7] bpf: Remove attach_type in sockmap_link Tao Chen
2025-07-11 17:39   ` John Fastabend
2025-07-10  3:20 ` [PATCH bpf-next v4 4/7] bpf: Remove location field in tcx_link Tao Chen
2025-07-11 17:37   ` John Fastabend
2025-07-10  3:20 ` [PATCH bpf-next v4 5/7] bpf: Remove attach_type in bpf_netns_link Tao Chen
2025-07-10  3:20 ` [PATCH bpf-next v4 6/7] bpf: Remove attach_type in bpf_tracing_link Tao Chen
2025-07-10  3:20 ` [PATCH bpf-next v4 7/7] netkit: Remove location field in netkit_link Tao Chen
2025-07-11 18:00 ` [PATCH bpf-next v4 0/7] Move attach_type into bpf_link patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250710032038.888700-1-chen.dylane@linux.dev \
    --to=chen.dylane@linux.dev \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=coreteam@netfilter.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=haoluo@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=jakub@cloudflare.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kadlec@netfilter.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mattbobrowski@google.com \
    --cc=mhiramat@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=razor@blackwall.org \
    --cc=rostedt@goodmis.org \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=willemb@google.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.