From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Simon Horman <horms@kernel.org>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next] ethtool: Fix set RXFH for drivers without RXFH fields support
Date: Thu, 10 Jul 2025 06:37:29 -0700 [thread overview]
Message-ID: <20250710063729.08ae71e6@kernel.org> (raw)
In-Reply-To: <a6341aa1-dd8b-4449-ba95-38bb067d6483@nvidia.com>
On Thu, 10 Jul 2025 14:17:11 +0300 Gal Pressman wrote:
> > We could add a:
> >
> > if (WARN_ON(ops->supported_input_xfrm && !ops->get_rxfh_fields))
> > return -EINVAL;
> >
> > into ethtool_check_ops() and we'd be both safe and slightly faster.
>
> This is a step further.
>
> There could be a driver that allows setting of input xfrm but not rxfh
> fields. Failing the netdevice registration is different than skipping
> ethtool_check_flow_types().
>
> Maybe there are no such devices and we shouldn't care?
Note that we're talking about the get. It's still perfectly fine for
the hypothetical driver to not support _changing_ the fields, the fields
be hardwired. But we need to know what fields the device is using to
validate the xfrm is correct.
prev parent reply other threads:[~2025-07-10 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 15:32 [PATCH net-next] ethtool: Fix set RXFH for drivers without RXFH fields support Gal Pressman
2025-07-10 0:25 ` Jakub Kicinski
2025-07-10 11:17 ` Gal Pressman
2025-07-10 13:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710063729.08ae71e6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.