From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0B03C83F17 for ; Thu, 10 Jul 2025 12:54:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FC7310E8C5; Thu, 10 Jul 2025 12:54:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Zh1T5PRE"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28DE310E8C3; Thu, 10 Jul 2025 12:54:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D365746EFF; Thu, 10 Jul 2025 12:54:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90ED4C4CEF5; Thu, 10 Jul 2025 12:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752152089; bh=7XmDQ19LlrT/ee4FW7YiS+UMjRIWOrZtAU1md2emjzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zh1T5PREai1yz3rn3CBHgF13mDoKB2msCw3lhEJa8I2n20i+aVL4VRFnKoDfhNLva 4Pqw6ldf+HSL3yoRg3PJKd3FRJ14VyNYCeYdcvi0X+/OOqjku8kpci5bcsXjlt3POb S9ruS4LGiTPhehntJ7q04fQ9uTyPGqMsvPt5NRckfhfkylJ3A5Oi/p68ZEnGf+sbtN 6XmaChNLKFEYb5vMLp1DQWHq960WmJOO9s87R1GIcOsQBp4b+HKQP7AOdGpkgcbU5v 0pvFYC7MIZiTu6D/asJjPayMpMUuLlMcarhObtcSZeV4y/jaGEsgM4E0jz0BOvSwb3 Tt5v6EdfH+BNQ== From: Philipp Stanner To: Danilo Krummrich , David Airlie , Simona Vetter , Matthew Brost , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Thomas Zimmermann , Tvrtko Ursulin , Pierre-Eric Pelloux-Prayer Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v4 5/8] drm/sched: Warn if pending_list is not empty Date: Thu, 10 Jul 2025 14:54:09 +0200 Message-ID: <20250710125412.128476-7-phasta@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250710125412.128476-2-phasta@kernel.org> References: <20250710125412.128476-2-phasta@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Signed-off-by: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index a971f0c9e6e0..d94270cf8bf5 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -1414,6 +1414,9 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched) sched->ready = false; kfree(sched->sched_rq); sched->sched_rq = NULL; + + if (!list_empty(&sched->pending_list)) + dev_warn(sched->dev, "Tearing down scheduler while jobs are pending!\n"); } EXPORT_SYMBOL(drm_sched_fini); -- 2.49.0