From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next V6 02/13] net/mlx5: Implement cqe_compress_type via devlink params
Date: Thu, 10 Jul 2025 15:16:57 -0700 [thread overview]
Message-ID: <20250710151657.5221ffcb@kernel.org> (raw)
In-Reply-To: <aG9TUPziunm1tRgR@x130>
On Wed, 9 Jul 2025 22:44:48 -0700 Saeed Mahameed wrote:
> >You already have a rx_cqe_compress ethtool priv flag.
> >Why is this needed and how it differs.
> >Is it just the default value for the ethtool setting?
>
> cqe compression can be enabled or disabled per queue,
> the priv flag is to enable/disable it on the netdev queues.
>
> This permanent devlink parameter selects the internal ASIC
> mechanism/algorithm for compression which is global for
> all the queues that enable compression.
makes sense, please extend the docs..
next prev parent reply other threads:[~2025-07-10 22:16 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 3:04 [PATCH net-next V6 00/13] devlink, mlx5: Add new parameters for link management and SRIOV/eSwitch configurations Saeed Mahameed
2025-07-09 3:04 ` [PATCH net-next V6 01/13] devlink: Add 'total_vfs' generic device param Saeed Mahameed
2025-07-09 8:36 ` Simon Horman
2025-07-10 2:53 ` Jakub Kicinski
2025-07-10 5:38 ` Saeed Mahameed
2025-09-02 21:24 ` Jacob Keller
2025-09-03 21:32 ` Saeed Mahameed
2025-07-09 3:04 ` [PATCH net-next V6 02/13] net/mlx5: Implement cqe_compress_type via devlink params Saeed Mahameed
2025-07-09 8:37 ` Simon Horman
2025-07-09 9:06 ` Subbaraya Sundeep
2025-07-10 5:51 ` Saeed Mahameed
2025-07-11 16:19 ` Subbaraya Sundeep
2025-07-10 2:53 ` Jakub Kicinski
2025-07-10 5:44 ` Saeed Mahameed
2025-07-10 22:16 ` Jakub Kicinski [this message]
2025-07-09 3:04 ` [PATCH net-next V6 03/13] net/mlx5: Implement devlink enable_sriov parameter Saeed Mahameed
2025-07-09 8:37 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 04/13] net/mlx5: Implement devlink total_vfs parameter Saeed Mahameed
2025-07-09 8:37 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 05/13] devlink: pass struct devlink_port * as arg to devlink_nl_param_fill() Saeed Mahameed
2025-07-09 8:38 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 06/13] devlink: Implement port params registration Saeed Mahameed
2025-07-09 8:38 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 07/13] devlink: Implement get/dump netlink commands for port params Saeed Mahameed
2025-07-09 8:38 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 08/13] devlink: Implement set netlink command " Saeed Mahameed
2025-07-09 8:40 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 09/13] devlink: Add 'keep_link_up' generic devlink device param Saeed Mahameed
2025-07-09 8:40 ` Simon Horman
2025-07-10 2:58 ` Jakub Kicinski
2025-07-10 6:04 ` Saeed Mahameed
2025-07-10 12:45 ` Jiri Pirko
2025-07-10 22:24 ` Jakub Kicinski
2025-08-28 20:09 ` Saeed Mahameed
2025-08-28 22:38 ` Jakub Kicinski
2025-09-02 19:02 ` Saeed Mahameed
2025-09-02 21:57 ` Jacob Keller
2025-09-03 6:45 ` Saeed Mahameed
2025-09-03 19:59 ` Jacob Keller
2025-09-03 21:30 ` Saeed Mahameed
2025-07-09 3:04 ` [PATCH net-next V6 10/13] net/mlx5: Implement devlink keep_link_up port parameter Saeed Mahameed
2025-07-09 8:40 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 11/13] devlink: Throw extack messages on param value validation error Saeed Mahameed
2025-07-09 8:40 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 12/13] devlink: Implement devlink param multi attribute nested data values Saeed Mahameed
2025-07-09 8:41 ` Simon Horman
2025-07-09 3:04 ` [PATCH net-next V6 13/13] net/mlx5: Implement eSwitch hairpin per prio buffers devlink params Saeed Mahameed
2025-07-09 8:41 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710151657.5221ffcb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jiri@nvidia.com \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.