From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] common/rc: remove useless _pgrep funcion
Date: Thu, 10 Jul 2025 09:14:37 -0700 [thread overview]
Message-ID: <20250710161437.GA2672039@frogsfrogsfrogs> (raw)
In-Reply-To: <20250622203947.797199-1-zlang@kernel.org>
On Mon, Jun 23, 2025 at 04:39:46AM +0800, Zorro Lang wrote:
> The _pgrep() function isn't used anymore, remove it.
>
> Signed-off-by: Zorro Lang <zlang@kernel.org>
Yeah, seems fine to me.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> common/rc | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index fbab26b25..a27f87a0b 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -36,16 +36,6 @@ _pkill()
> pkill "$@"
> }
>
> -# Find only the test processes started by this test
> -_pgrep()
> -{
> - if [ "$FSTESTS_ISOL" = "setsid" ]; then
> - pgrep --session 0 "$@"
> - else
> - pgrep "$@"
> - fi
> -}
> -
> # Common execution handling for fsstress invocation.
> #
> # We need per-test fsstress binaries because of the way fsstress forks and
> --
> 2.47.1
>
>
prev parent reply other threads:[~2025-07-10 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 20:39 [PATCH 1/2] common/rc: remove useless _pgrep funcion Zorro Lang
2025-06-22 20:39 ` [PATCH 2/2] common/rc: _add_dmesg_filter returns when RESULT_DIR is null Zorro Lang
2025-07-10 16:15 ` Darrick J. Wong
2025-07-10 16:09 ` [PATCH 1/2] common/rc: remove useless _pgrep funcion Zorro Lang
2025-07-10 16:14 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710161437.GA2672039@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.