Re: [PATCH net-next v3 2/8] net: s/dev_get_port_parent_id/netif_get_port_parent_id/

[Jakub Kicinski <kuba@kernel.org>]

On Tue,  8 Jul 2025 14:38:23 -0700 Stanislav Fomichev wrote:
>  /**
> - *	dev_get_port_parent_id - Get the device's port parent identifier
> - *	@dev: network device
> - *	@ppid: pointer to a storage for the port's parent identifier
> - *	@recurse: allow/disallow recursion to lower devices
> + * netif_get_port_parent_id() - Get the device's port parent identifier
> + * @dev: network device
> + * @ppid: pointer to a storage for the port's parent identifier
> + * @recurse: allow/disallow recursion to lower devices
>   *
> - *	Get the devices's port parent identifier
> + * Get the devices's port parent identifier
>   */

At the risk of annoying you I'd suggest adding a Return: statement
while you touch these kdocs. Here are some popular phrasings:

 * Return: 0 on success, or a negative error code on failure
 * Return: 0 on success, -errno on failure.
 * Return: 0 on success, -errno otherwise.