From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Subject: [PATCH net-next 09/11] net: gianfar: remove free_gfar_dev
Date: Thu, 10 Jul 2025 13:40:30 -0700 [thread overview]
Message-ID: <20250710204032.650152-10-rosenp@gmail.com> (raw)
In-Reply-To: <20250710204032.650152-1-rosenp@gmail.com>
Use devm for kzalloc. Allows to remove free_gfar_dev as devm handles
freeing it now.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/ethernet/freescale/gianfar.c | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index 2e9971ae475e..a93244415274 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -467,17 +467,6 @@ static void unmap_group_regs(struct gfar_private *priv)
iounmap(priv->gfargrp[i].regs);
}
-static void free_gfar_dev(struct gfar_private *priv)
-{
- int i, j;
-
- for (i = 0; i < priv->num_grps; i++)
- for (j = 0; j < GFAR_NUM_IRQS; j++) {
- kfree(priv->gfargrp[i].irqinfo[j]);
- priv->gfargrp[i].irqinfo[j] = NULL;
- }
-}
-
static void disable_napi(struct gfar_private *priv)
{
int i;
@@ -505,8 +494,8 @@ static int gfar_parse_group(struct device_node *np,
int i;
for (i = 0; i < GFAR_NUM_IRQS; i++) {
- grp->irqinfo[i] = kzalloc(sizeof(struct gfar_irqinfo),
- GFP_KERNEL);
+ grp->irqinfo[i] = devm_kzalloc(
+ priv->dev, sizeof(struct gfar_irqinfo), GFP_KERNEL);
if (!grp->irqinfo[i])
return -ENOMEM;
}
@@ -811,7 +800,6 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
gfar_free_rx_queues(priv);
tx_alloc_failed:
gfar_free_tx_queues(priv);
- free_gfar_dev(priv);
return err;
}
@@ -3324,7 +3312,6 @@ static int gfar_probe(struct platform_device *ofdev)
gfar_free_tx_queues(priv);
of_node_put(priv->phy_node);
of_node_put(priv->tbi_node);
- free_gfar_dev(priv);
return err;
}
@@ -3342,7 +3329,6 @@ static void gfar_remove(struct platform_device *ofdev)
unmap_group_regs(priv);
gfar_free_rx_queues(priv);
gfar_free_tx_queues(priv);
- free_gfar_dev(priv);
}
#ifdef CONFIG_PM
--
2.50.0
next prev parent reply other threads:[~2025-07-10 20:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 20:40 [PATCH net-next 00/11] gianfar and mdio: modernize Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 01/11] net: fsl_pq_mdio: use dev variable in _probe Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 02/11] net: fsl_pq_mdio: use devm for mdiobus_alloc_size Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 03/11] net: fsl_pq_mdio: use platform_get_resource Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 04/11] net: fsl_pq_mdio: use devm for of_iomap Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 05/11] net: fsl_pq_mdio: return directly in probe Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 06/11] net: gianfar: use devm_alloc_etherdev_mqs Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 07/11] net: gianfar: use devm for register_netdev Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 08/11] net: gianfar: assign ofdev to priv struct Rosen Penev
2025-07-10 20:40 ` Rosen Penev [this message]
2025-07-10 20:40 ` [PATCH net-next 10/11] net: gianfar: alloc queues with devm Rosen Penev
2025-07-10 20:40 ` [PATCH net-next 11/11] net: gianfar: iomap " Rosen Penev
2025-07-10 22:15 ` [PATCH net-next 00/11] gianfar and mdio: modernize Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2024-12-02 21:23 Rosen Penev
2024-12-02 21:23 ` [PATCH net-next 09/11] net: gianfar: remove free_gfar_dev Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710204032.650152-10-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.