From: Tom Rini <trini@konsulko.com>
To: Mikko Rapeli <mikko.rapeli@linaro.org>
Cc: u-boot@lists.denx.de, Adriano Cordova <adrianox@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH] scripts/Makefile.lib: fix *_efi.so dependency to PLATFORM_LIBGCC
Date: Thu, 10 Jul 2025 16:25:11 -0600 [thread overview]
Message-ID: <20250710222511.GD6424@bill-the-cat> (raw)
In-Reply-To: <aG_XXm3Cvm6DJPQy@nuoska>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Thu, Jul 10, 2025 at 06:08:14PM +0300, Mikko Rapeli wrote:
> Hi, moving patch review from oe-core list to u-boot:
>
> On Thu, Jul 10, 2025 at 08:59:03AM -0600, Tom Rini wrote:
> <snip>
> > I cleared you patch (and moderation flag) but I don't think the above
> > works in all cases since PLATFORM_LIBGCC can have a number of values
> > only one of which is that file.
>
> Right. Should I make the dependency conditional to
> CONFIG_USE_PRIVATE_LIBGCC like it's set in Makefile?
>
> I don't see another variable for lib.a to use in
> scripts/Makefile.lib
Yes, that's my first thought as well. But that might also fail when
CC_COVERAGE is enabled. So you might need to adjust that logic too.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-07-10 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 1:29 [PATCH] u-boot: upgrade 2025.04 -> 2025.07 Fabio Estevam
2025-07-08 12:37 ` [OE-core] " Mathieu Dubois-Briand
2025-07-08 17:04 ` Fabio Estevam
2025-07-08 17:57 ` Tom Rini
2025-07-09 8:21 ` Mathieu Dubois-Briand
2025-07-09 14:29 ` Tom Rini
2025-07-10 13:02 ` Mikko Rapeli
[not found] ` <1850E573A97965CE.21176@lists.openembedded.org>
2025-07-10 14:50 ` Mikko Rapeli
2025-07-10 14:59 ` Tom Rini
2025-07-10 14:44 ` [PATCH] scripts/Makefile.lib: fix *_efi.so dependency to PLATFORM_LIBGCC Mikko Rapeli
2025-07-10 15:08 ` Mikko Rapeli
2025-07-10 22:25 ` Tom Rini [this message]
2025-07-09 9:35 ` [OE-core] [PATCH] u-boot: upgrade 2025.04 -> 2025.07 Freihofer, Adrian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710222511.GD6424@bill-the-cat \
--to=trini@konsulko.com \
--cc=adrianox@gmail.com \
--cc=festevam@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=mikko.rapeli@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.