Re: [PATCH 12/72] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Replace clock-frequency in camera sensor node

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Konrad,

On Fri, Jul 11, 2025 at 02:25:14PM +0200, Konrad Dybcio wrote:
> On 7/10/25 7:47 PM, Laurent Pinchart wrote:
> > The clock-frequency for camera sensors has been deprecated in favour of
> > the assigned-clocks and assigned-clock-rates properties. Replace it in
> > the device tree.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  .../boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso      | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> > index 51f1a4883ab8..dbe1911d8e47 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> > @@ -44,7 +44,8 @@ camera@10 {
> >  
> >  		clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> >  		clock-names = "xvclk";
> > -		clock-frequency = <19200000>;
> > +		assigned-clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> > +		assigned-clock-rates = <19200000>;
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> (although your patches still seem to leave clk_set_rate in
> ov8856.c anyway?)

The call gets removed in patch 69/72 ([1]). It gets replaced by
devm_v4l2_sensor_clk_get_legacy(), which internally calls
clk_set_rate(), so the behaviour is preserved to avoid breaking backward
compatibility with old DTs.

[1] https://lore.kernel.org/linux-media/20250710174808.5361-70-laurent.pinchart@ideasonboard.com

-- 
Regards,

Laurent Pinchart