From: Tom Rini <trini@konsulko.com>
To: Yannic Moog <y.moog@phytec.de>
Cc: Simon Glass <sjg@chromium.org>,
Alper Nebi Yasak <alpernebiyasak@gmail.com>,
Bryan Brattlof <bb@ti.com>,
u-boot@lists.denx.de, Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH] binman: Fix typing for python >= 3.5
Date: Fri, 11 Jul 2025 09:04:16 -0600 [thread overview]
Message-ID: <20250711150416.GF6424@bill-the-cat> (raw)
In-Reply-To: <20250711-binman-typing-fix-v1-1-66ab075015ac@phytec.de>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Fri, Jul 11, 2025 at 11:23:27AM +0200, Yannic Moog wrote:
> To make it work with python 3.5 and 3.6, need type hints from the
> typing module.
>
> Reported-by: Tim Harvey <tharvey@gateworks.com>
> Fixes: 21bc3433a43d ("binman: rework dropping absent entries from packaged image")
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> ---
> tools/binman/etype/cbfs.py | 3 ++-
> tools/binman/etype/mkimage.py | 4 +++-
> tools/binman/etype/section.py | 4 ++--
> 3 files changed, 7 insertions(+), 4 deletions(-)
There's some seemingly unrelated spacing changes in here, can you please
drop them unless required? Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2025-07-11 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 9:23 [PATCH] binman: Fix typing for python >= 3.5 Yannic Moog
2025-07-11 15:04 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711150416.GF6424@bill-the-cat \
--to=trini@konsulko.com \
--cc=alpernebiyasak@gmail.com \
--cc=bb@ti.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.