All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
	Simon Horman <horms@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	bpf@vger.kernel.org, kernel-team@meta.com,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v5 3/3] selftests: net: add netpoll basic functionality test
Date: Fri, 11 Jul 2025 15:41:42 -0700	[thread overview]
Message-ID: <20250711154142.369aaae1@kernel.org> (raw)
In-Reply-To: <k45gwtae6yx3cjy5kprctlnw4wox5fnfd5yjlczgpyu2cw5bsj@dol2der4ykat>

On Fri, 11 Jul 2025 08:51:19 -0700 Breno Leitao wrote:
> > json=True please and you'll get a dict, on CLI you can try:
> > 
> > ethtool --json -g eth0  
> 
> Sure. I was parsing manually because some options do not have --json
> format. 
> 
> 	ethtool --json -l eth0
> 	ethtool: bad command line argument(s)
> 
> I haven't checked upstream, but, if this feature is upstream, is it worth
> implementing it?

I added it relatively recently. Looks like it's already here 
on my Fedora laptop, but not in the CI system! Let me update
it there, and you can assume --json -l to work in the test..

      reply	other threads:[~2025-07-11 22:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09  9:08 [PATCH net-next v5 0/3] selftest: net: Add selftest for netpoll Breno Leitao
2025-07-09  9:08 ` [PATCH net-next v5 1/3] selftests: drv-net: add helper/wrapper for bpftrace Breno Leitao
2025-07-09  9:08 ` [PATCH net-next v5 2/3] selftests: drv-net: Strip '@' prefix from bpftrace map keys Breno Leitao
2025-07-09  9:08 ` [PATCH net-next v5 3/3] selftests: net: add netpoll basic functionality test Breno Leitao
2025-07-11  1:45   ` Jakub Kicinski
2025-07-11 15:51     ` Breno Leitao
2025-07-11 22:41       ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250711154142.369aaae1@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.