From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC92AC83F1A for ; Fri, 11 Jul 2025 13:51:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaEAC-0007vR-GE; Fri, 11 Jul 2025 09:51:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaE5q-00072f-Cg for qemu-arm@nongnu.org; Fri, 11 Jul 2025 09:47:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaE5n-0001HS-Fq for qemu-arm@nongnu.org; Fri, 11 Jul 2025 09:47:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752241627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tzu7gL5TEUXY0GgzHKCVlqvUJUK48vtiNAdklCGRYpE=; b=QTBbXFqZ37U437hFnriZXt6xcaZZ7Q8/j06Ph2bPh+t7Z71kNMx8fEl039NdulkzukBmMP +yAPE1pwUetreaV0udiPqL2C6kiByHUky8PMxEUl/sJkjIg/eohyxjz0xGNW2IYVxCp10Z 9Sd6TIJyEoMOISHADsGnAc7rdPcPhrE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-Uz7-1sPoM4WrDIolQqc-pw-1; Fri, 11 Jul 2025 09:47:06 -0400 X-MC-Unique: Uz7-1sPoM4WrDIolQqc-pw-1 X-Mimecast-MFC-AGG-ID: Uz7-1sPoM4WrDIolQqc-pw_1752241625 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4eee2398bso1123464f8f.1 for ; Fri, 11 Jul 2025 06:47:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752241625; x=1752846425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tzu7gL5TEUXY0GgzHKCVlqvUJUK48vtiNAdklCGRYpE=; b=CrX+Jh46p3Hc9DSYH8A65j+hIthQ+r3cNvNAZSMkkL7R4CYbEWgwObyChoK9zCu+jz z1jOmN8NYyQLg13dGXTRffreQ46LaxBZDvSDLaTD1PX7LufyfuvL0bRRJysJw+iSsmnB OL8wD2md7BOe45GPpUMiynglK6JDWMrzaRd510O6QYmowKtvOi/swQE1wCD2a0QbrQLA dOcvJUKhocpIiY5vg8nhThlimfRH/UMB4trOeoWtacS90+6eFO/FgX2ovTc9X9fcDk5M FJthTzlcm4OjXKuyD7QLL1o0qjaP09SZMk5MFdNaQH1BHm2YdoI+cwJSc7bH3kYQD7qr 8tqA== X-Forwarded-Encrypted: i=1; AJvYcCUgCca4kWIXofJR8kfjjBjDXZisd1WkYlUmoFLO3K81ZSseM+b6sYp+oWxq4XyqQNLFLdlW/PSiuw==@nongnu.org X-Gm-Message-State: AOJu0YyLbM+cq6u4iQftmQt0GoEoTgQwfJZlb6fFfcuI8ey5Nxs5HxKx TQ7hj0mR0riHX5+SjAffdffO2IxVZneCFuzax8TXQS8tPw6SXPdE+Qt4BHd8jky5oMHiqE1Dfkh sigG+clSMM6wQCkWSHC4KHXptGhFZhpIGAULg4GEBMceFGXph5oFwrw== X-Gm-Gg: ASbGncv630Iu8xrH3h9dBPgsJWIuxUQSvlCN3F7TLyyFMO4jsGcFgTdWg1tJYjwuJV6 godSTLzRhHbQByZGlYGtfJO7v5hrIzuGPWqovhKzam2eEB1baCpc2BCH7EwO0WsNjzY4P+gmG2W mmm5csBAoPtpEsNdfrT11rIBMSLnX7XavktlQqkZRuI/qFcF8xRS7ZH3tm61xWxAbAZsKUs3FPk uk2VgivKsXOMckPbnEPjKZVGfY0g0ZsuwCOsWZXofiJ+YAKTacJRw4brwyGpTc2nyI9mgCRnFTJ VYx2Q/iS/vC6CKiWWksG1cFJ4FbKiQ== X-Received: by 2002:a05:6000:4a09:b0:3a4:e672:deef with SMTP id ffacd0b85a97d-3b5f35785abmr2243918f8f.36.1752241624650; Fri, 11 Jul 2025 06:47:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/6JIzGXIwMI3J8jQ81msIV7ZxZNlhV+ihkOAZUUBUTvhZ3eeoe9MLuSyarrRUghKtLSXWKQ== X-Received: by 2002:a05:6000:4a09:b0:3a4:e672:deef with SMTP id ffacd0b85a97d-3b5f35785abmr2243894f8f.36.1752241624155; Fri, 11 Jul 2025 06:47:04 -0700 (PDT) Received: from fedora ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8bd17b7sm4530650f8f.11.2025.07.11.06.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 06:47:03 -0700 (PDT) Date: Fri, 11 Jul 2025 15:47:01 +0200 From: Igor Mammedov To: Eric Auger Cc: eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, Jonathan.Cameron@huawei.com, gustavo.romero@linaro.org, anisinha@redhat.com, mst@redhat.com, shannon.zhaosl@gmail.com, pbonzini@redhat.com, philmd@linaro.org, alex.bennee@linaro.org Subject: Re: [PATCH v6 34/36] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test Message-ID: <20250711154701.0f394671@fedora> In-Reply-To: <20250708142437.1344644-35-eric.auger@redhat.com> References: <20250708142437.1344644-1-eric.auger@redhat.com> <20250708142437.1344644-35-eric.auger@redhat.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: j9MNbKYfw_vSd5XyKeTfPBaY8VBmB6q-MKeW_Hvk4No_1752241625 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Tue, 8 Jul 2025 16:23:16 +0200 Eric Auger wrote: > From: Gustavo Romero > > Add 2 new tests: > - test_acpi_aarch64_virt_acpi_pci_hotplug tests the acpi pci hotplug > using -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > - test_acpi_aarch64_virt_pcie_root_port_hpoff tests static-acpi index > on a root port with disabled hotplug tests a bit simple, I wonder if we could reuse related x86 variants for that (as those test a bit more corner cases with a more complicated topology). It's not a blocker and doing this of cause can be done on top. > > Signed-off-by: Gustavo Romero > Signed-off-by: Eric Auger > Reviewed-by: Jonathan Cameron > > --- > v3 -> v4: > - add -device pci-testdev for the first test case > - fix the chassis > - add a test for static acpi-index > --- > tests/qtest/bios-tables-test.c | 52 ++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index 357bcefd37..1074b8d67a 100644 > --- a/tests/qtest/bios-tables-test.c > +++ b/tests/qtest/bios-tables-test.c > @@ -1643,6 +1643,54 @@ static void test_acpi_aarch64_virt_tcg_memhp(void) > > } > > +static void test_acpi_aarch64_virt_acpi_pci_hotplug(void) > +{ > + test_data data = { > + .machine = "virt", > + .arch = "aarch64", > + .tcg_only = true, > + .uefi_fl1 = "pc-bios/edk2-aarch64-code.fd", > + .uefi_fl2 = "pc-bios/edk2-arm-vars.fd", > + .cd = "tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2", > + .ram_start = 0x40000000ULL, > + .scan_len = 256ULL * MiB, > + .variant = ".acpipcihp", > + }; > + > + /* Use ACPI PCI Hotplug */ > + test_acpi_one(" -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on" > + " -cpu cortex-a57" > + " -device pcie-root-port,id=pcie.1,bus=pcie.0,chassis=0,slot=1,addr=7.0" > + " -device pci-testdev,bus=pcie.1", > + &data); > + > + free_test_data(&data); > +} > + > +static void test_acpi_aarch64_virt_pcie_root_port_hpoff(void) > +{ > + test_data data = { > + .machine = "virt", > + .arch = "aarch64", > + .tcg_only = true, > + .uefi_fl1 = "pc-bios/edk2-aarch64-code.fd", > + .uefi_fl2 = "pc-bios/edk2-arm-vars.fd", > + .cd = "tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2", > + .ram_start = 0x40000000ULL, > + .scan_len = 256ULL * MiB, > + .variant = ".hpoffacpiindex", > + }; > + > + /* turn hotplug off on the pcie-root-port and use static acpi-index*/ > + test_acpi_one(" -device pcie-root-port,id=pcie.1,chassis=0," > + "slot=1,hotplug=off,addr=7.0" > + " -device pci-testdev,bus=pcie.1,acpi-index=12" > + " -cpu cortex-a57", > + &data); > + > + free_test_data(&data); > +} > + > static void test_acpi_microvm_prepare(test_data *data) > { > data->machine = "microvm"; > @@ -2602,6 +2650,10 @@ int main(int argc, char *argv[]) > qtest_add_func("acpi/virt/numamem", > test_acpi_aarch64_virt_tcg_numamem); > qtest_add_func("acpi/virt/memhp", test_acpi_aarch64_virt_tcg_memhp); > + qtest_add_func("acpi/virt/acpipcihp", > + test_acpi_aarch64_virt_acpi_pci_hotplug); > + qtest_add_func("acpi/virt/hpoffacpiindex", > + test_acpi_aarch64_virt_pcie_root_port_hpoff); > qtest_add_func("acpi/virt/pxb", test_acpi_aarch64_virt_tcg_pxb); > qtest_add_func("acpi/virt/oem-fields", > test_acpi_aarch64_virt_oem_fields);