All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	Marc Zyngier <maz@kernel.org>
Subject: [PATCH 05/10] arm64: mm: Re-implement the __tlbi_level macro in C
Date: Fri, 11 Jul 2025 17:17:27 +0100	[thread overview]
Message-ID: <20250711161732.384-6-will@kernel.org> (raw)
In-Reply-To: <20250711161732.384-1-will@kernel.org>

__tlbi_level() is just a simple macro around __tlbi_level_op(), so merge
the two into a single C function. Drop the redundant comparison of
'u32 level' against 0 and tidy up the code a little while we're at it.

Signed-off-by: Will Deacon <will@kernel.org>
---
 arch/arm64/include/asm/tlbflush.h | 25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
index 728b00f3e1f4..ddd77e92b268 100644
--- a/arch/arm64/include/asm/tlbflush.h
+++ b/arch/arm64/include/asm/tlbflush.h
@@ -128,8 +128,17 @@ enum tlbi_op {
 	___GEN_TLBI_OP_CASE(op);					\
 		break
 
-static __always_inline void __tlbi_level_op(const enum tlbi_op op, u64 arg)
+static __always_inline void __tlbi_level(const enum tlbi_op op, u64 addr, u32 level)
 {
+	u64 arg = addr;
+
+	if (alternative_has_cap_unlikely(ARM64_HAS_ARMv8_4_TTL) && level <= 3) {
+		u64 ttl = level | (get_trans_granule() << 2);
+
+		arg &= ~TLBI_TTL_MASK;
+		arg |= FIELD_PREP(TLBI_TTL_MASK, ttl);
+	}
+
 	switch (op) {
 	__GEN_TLBI_OP_ASID_CASE(vae1is);
 	__GEN_TLBI_OP_CASE(vae2is);
@@ -145,20 +154,6 @@ static __always_inline void __tlbi_level_op(const enum tlbi_op op, u64 arg)
 #undef __GEN_TLBI_OP_ASID_CASE
 #undef ___GEN_TLBI_OP_CASE
 
-#define __tlbi_level(op, addr, level) do {				\
-	u64 arg = addr;							\
-									\
-	if (alternative_has_cap_unlikely(ARM64_HAS_ARMv8_4_TTL) &&	\
-	    level >= 0 && level <= 3) {					\
-		u64 ttl = level & 3;					\
-		ttl |= get_trans_granule() << 2;			\
-		arg &= ~TLBI_TTL_MASK;					\
-		arg |= FIELD_PREP(TLBI_TTL_MASK, ttl);			\
-	}								\
-									\
-	__tlbi_level_op(op, arg);					\
-} while(0)
-
 /*
  * This macro creates a properly formatted VA operand for the TLB RANGE. The
  * value bit assignments are:
-- 
2.50.0.727.gbf7dc18ff4-goog



  parent reply	other threads:[~2025-07-11 17:08 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11 16:17 [PATCH 00/10] arm64: Replace TLB invalidation preprocessor macros with C functions Will Deacon
2025-07-11 16:17 ` [PATCH 01/10] arm64: mm: Introduce a C wrapper for by-level TLB invalidation helpers Will Deacon
2025-07-14  8:38   ` Ryan Roberts
2025-07-11 16:17 ` [PATCH 02/10] arm64: mm: Introduce a C wrapper for by-range " Will Deacon
2025-07-14  8:26   ` Ryan Roberts
2025-07-11 16:17 ` [PATCH 03/10] arm64: mm: Implicitly invalidate user ASID based on TLBI operation Will Deacon
2025-07-14  8:44   ` Ryan Roberts
2025-07-14  9:46     ` Ryan Roberts
2025-07-11 16:17 ` [PATCH 04/10] arm64: mm: Remove unused 'tlbi_user' argument from __flush_tlb_range_op() Will Deacon
2025-07-11 16:17 ` Will Deacon [this message]
2025-07-14  9:02   ` [PATCH 05/10] arm64: mm: Re-implement the __tlbi_level macro in C Ryan Roberts
2025-07-11 16:17 ` [PATCH 06/10] arm64: mm: Simplify __TLBI_RANGE_NUM() macro Will Deacon
2025-07-14  9:06   ` Ryan Roberts
2025-07-15  5:13   ` Dev Jain
2025-07-11 16:17 ` [PATCH 07/10] arm64: mm: Push __TLBI_VADDR() into __tlbi_level() Will Deacon
2025-07-11 16:17 ` [PATCH 08/10] arm64: mm: Inline __TLBI_VADDR_RANGE() into __tlbi_range() Will Deacon
2025-07-14  9:17   ` Ryan Roberts
2025-07-11 16:17 ` [PATCH 09/10] arm64: mm: Simplify __flush_tlb_range_limit_excess() Will Deacon
2025-07-14  9:30   ` Ryan Roberts
2025-07-15  5:38     ` Dev Jain
2025-07-11 16:17 ` [PATCH 10/10] arm64: mm: Re-implement the __flush_tlb_range_op macro in C Will Deacon
2025-07-11 18:16   ` Linus Torvalds
2025-07-13 13:35     ` Will Deacon
2025-07-14  9:44   ` Ryan Roberts
2025-12-10 12:29 ` [PATCH 00/10] arm64: Replace TLB invalidation preprocessor macros with C functions Ryan Roberts
2025-12-12 12:12   ` Ryan Roberts
2025-12-12 20:13     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250711161732.384-6-will@kernel.org \
    --to=will@kernel.org \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.