From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6872E28C2C1 for ; Fri, 11 Jul 2025 11:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752233894; cv=none; b=ig2sVWfmSG2t/eQZFRkot9Mx6b+57r0uIbdhsHo4xZDMLLNb5XEN6zCugMH+rFLSFscSl8sH7iJi8sF7Ihe/+dnwjzDRU1jBcsd40pRfC1ScsuSpW1HW/rzooq/Eg2Pp70/BZ4qqQhNzZ3ARQJ/TbiY9jX/u+w0Qh3px5Av2S2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752233894; c=relaxed/simple; bh=lSvoT5vt44Jp8PaBB+rkOYldsL6euG1VhFB9xopGaRg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=poY22w+1AKIt98eZ0bJT3uWtMsj68WsG5BiODwo9FpoysKaYuWKdGhjoxotp/5p0lQT4dxQSHLY1SwrU1BKzSY2jC4u8a3GK6L9g/2kOEpSXW5+D8uwCm5Fn5785FM1T9ARuYL6BzJdTR/7vW0lE4ky+u4qn07EhpEw7wq60lhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=a4Mb4YtS; arc=none smtp.client-ip=140.211.166.137 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="a4Mb4YtS" Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E02F940C25 for ; Fri, 11 Jul 2025 11:38:12 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org X-Spam-Flag: NO X-Spam-Score: -2.101 X-Spam-Level: Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4dq_1hzXxdQy for ; Fri, 11 Jul 2025 11:38:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 2BD3140C1E Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2BD3140C1E Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=a4Mb4YtS Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2BD3140C1E for ; Fri, 11 Jul 2025 11:38:11 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A02B46115D; Fri, 11 Jul 2025 11:38:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1204C4CEED; Fri, 11 Jul 2025 11:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752233890; bh=lSvoT5vt44Jp8PaBB+rkOYldsL6euG1VhFB9xopGaRg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a4Mb4YtSbYGdHc+iYwE0/RCEEQ6a3YMKvwQuJcuiO0tb8cmWBC4IcbaVt4z825U/W vybKH50YMqS17MNTfNPQuWFapCMc0cKKCFviufU97su4HTgduYgw8Cls4YOj0k21z+ trsZJWu01xXAWVtGdAx/cdogG3k7aZxapr//o24I= Date: Fri, 11 Jul 2025 13:38:07 +0200 From: Greg KH To: Steven Rostedt Cc: Christoph Hellwig , Mathieu Desnoyers , linux-kernel@vger.kernel.org, Josh Poimboeuf , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Andrii Nakryiko , Indu Bhagat , "Jose E. Marchesi" , Beau Belgrave , Jens Remus , Linus Torvalds , Andrew Morton , tech-board-discuss@lists.linuxfoundation.org Subject: Re: [RFC PATCH 2/5] unwind: Export unwind_user symbol to GPL modules Message-ID: <2025071124-cola-slouching-9dd2@gregkh> References: <20250709212556.32777-1-mathieu.desnoyers@efficios.com> <20250709212556.32777-3-mathieu.desnoyers@efficios.com> <20250711065742.00d6668b@gandalf.local.home> Precedence: bulk X-Mailing-List: tech-board-discuss@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250711065742.00d6668b@gandalf.local.home> On Fri, Jul 11, 2025 at 06:57:42AM -0400, Steven Rostedt wrote: > > [ Adding the TAB to this as well ] > > On Fri, 11 Jul 2025 00:36:28 -0700 > Christoph Hellwig wrote: > > > On Wed, Jul 09, 2025 at 05:25:49PM -0400, Mathieu Desnoyers wrote: > > > Allow the unwind_user symbol to be used by GPL modules, for instance > > > LTTng. > > > > I don't see a LTTng submission or any other user in this series. > > So the usual prohibition against adding unused exports applies here > > as usual. > > I want to bring up this discussion. I understand there's a policy not to > add EXPORT_SYMBOL_GPL() unless there's a current user of it in the kernel > proper. My question is, does this policy have to be draconian? It's not "draconian", it is "we do not add exports for stuff that is not in our kernel tree." Simple, direct, and obvious. We have no idea how, or if, external modules do anything with apis that we export and do not use internally, so we can't change them without breaking anything, so it's simpler and more obvious to not even attempt to care about them. If external users want to use a symbol, they should get merged into the tree. Yes, lttng is a "good citizen" of the kernel community, and yes, it's not merged into the tree, but that's not our issue, and living outside of the tree has it's penalities, both economic and technical. This is one of those penalities, sorry. So no, we shouldn't change this at all. And I think we need to start doing more of the "only export this symbol for this subsystem/module" trimming as well. I see the horrors that out-of-tree kernel code does and by removing the ability of them to even get access to the things they do have access to today, would be good for everyone involved (i.e. our community, AND the users of Linux to allow them to have a more stable and trustworthy base to rely on.) thanks, greg k-h