[rgushchin:lru_note_cost.1 1/1] mm/vmscan.c:2076:34: error: passing argument 1 of 'scan_balance_biased' from incompatible pointer type

[kernel test robot <lkp@intel.com>]

tree:   https://github.com/rgushchin/linux.git lru_note_cost.1
head:   d5e513cdf1ec233fa62389576f6ddb1c730d9994
commit: d5e513cdf1ec233fa62389576f6ddb1c730d9994 [1/1] mm: skip lru_note_cost() when scanning only file or anon
config: i386-buildonly-randconfig-002-20250712 (https://download.01.org/0day-ci/archive/20250712/202507120159.xJZov3rL-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250712/202507120159.xJZov3rL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507120159.xJZov3rL-lkp@intel.com/

All errors (new ones prefixed by >>):

   mm/vmscan.c: In function 'shrink_inactive_list':
>> mm/vmscan.c:2076:34: error: passing argument 1 of 'scan_balance_biased' from incompatible pointer type [-Werror=incompatible-pointer-types]
    2076 |         if (!scan_balance_biased(&sc))
         |                                  ^~~
         |                                  |
         |                                  struct scan_control **
   mm/vmscan.c:1999:54: note: expected 'struct scan_control *' but argument is of type 'struct scan_control **'
    1999 | static bool scan_balance_biased(struct scan_control *sc)
         |                                 ~~~~~~~~~~~~~~~~~~~~~^~
   mm/vmscan.c: In function 'shrink_active_list':
   mm/vmscan.c:2226:48: error: passing argument 1 of 'scan_balance_biased' from incompatible pointer type [-Werror=incompatible-pointer-types]
    2226 |         if (nr_rotated && !scan_balance_biased(&sc))
         |                                                ^~~
         |                                                |
         |                                                struct scan_control **
   mm/vmscan.c:1999:54: note: expected 'struct scan_control *' but argument is of type 'struct scan_control **'
    1999 | static bool scan_balance_biased(struct scan_control *sc)
         |                                 ~~~~~~~~~~~~~~~~~~~~~^~
   cc1: some warnings being treated as errors


vim +/scan_balance_biased +2076 mm/vmscan.c

  2009	
  2010	/*
  2011	 * shrink_inactive_list() is a helper for shrink_node().  It returns the number
  2012	 * of reclaimed pages
  2013	 */
  2014	static unsigned long shrink_inactive_list(unsigned long nr_to_scan,
  2015			struct lruvec *lruvec, struct scan_control *sc,
  2016			enum lru_list lru)
  2017	{
  2018		LIST_HEAD(folio_list);
  2019		unsigned long nr_scanned;
  2020		unsigned int nr_reclaimed = 0;
  2021		unsigned long nr_taken;
  2022		struct reclaim_stat stat;
  2023		bool file = is_file_lru(lru);
  2024		enum vm_event_item item;
  2025		struct pglist_data *pgdat = lruvec_pgdat(lruvec);
  2026		bool stalled = false;
  2027	
  2028		while (unlikely(too_many_isolated(pgdat, file, sc))) {
  2029			if (stalled)
  2030				return 0;
  2031	
  2032			/* wait a bit for the reclaimer. */
  2033			stalled = true;
  2034			reclaim_throttle(pgdat, VMSCAN_THROTTLE_ISOLATED);
  2035	
  2036			/* We are about to die and free our memory. Return now. */
  2037			if (fatal_signal_pending(current))
  2038				return SWAP_CLUSTER_MAX;
  2039		}
  2040	
  2041		lru_add_drain();
  2042	
  2043		spin_lock_irq(&lruvec->lru_lock);
  2044	
  2045		nr_taken = isolate_lru_folios(nr_to_scan, lruvec, &folio_list,
  2046					     &nr_scanned, sc, lru);
  2047	
  2048		__mod_node_page_state(pgdat, NR_ISOLATED_ANON + file, nr_taken);
  2049		item = PGSCAN_KSWAPD + reclaimer_offset(sc);
  2050		if (!cgroup_reclaim(sc))
  2051			__count_vm_events(item, nr_scanned);
  2052		count_memcg_events(lruvec_memcg(lruvec), item, nr_scanned);
  2053		__count_vm_events(PGSCAN_ANON + file, nr_scanned);
  2054	
  2055		spin_unlock_irq(&lruvec->lru_lock);
  2056	
  2057		if (nr_taken == 0)
  2058			return 0;
  2059	
  2060		nr_reclaimed = shrink_folio_list(&folio_list, pgdat, sc, &stat, false,
  2061						 lruvec_memcg(lruvec));
  2062	
  2063		spin_lock_irq(&lruvec->lru_lock);
  2064		move_folios_to_lru(lruvec, &folio_list);
  2065	
  2066		__mod_lruvec_state(lruvec, PGDEMOTE_KSWAPD + reclaimer_offset(sc),
  2067						stat.nr_demoted);
  2068		__mod_node_page_state(pgdat, NR_ISOLATED_ANON + file, -nr_taken);
  2069		item = PGSTEAL_KSWAPD + reclaimer_offset(sc);
  2070		if (!cgroup_reclaim(sc))
  2071			__count_vm_events(item, nr_reclaimed);
  2072		count_memcg_events(lruvec_memcg(lruvec), item, nr_reclaimed);
  2073		__count_vm_events(PGSTEAL_ANON + file, nr_reclaimed);
  2074		spin_unlock_irq(&lruvec->lru_lock);
  2075	
> 2076		if (!scan_balance_biased(&sc))
  2077			lru_note_cost(lruvec, file, stat.nr_pageout,
  2078				      nr_scanned - nr_reclaimed);
  2079	
  2080		/*
  2081		 * If dirty folios are scanned that are not queued for IO, it
  2082		 * implies that flushers are not doing their job. This can
  2083		 * happen when memory pressure pushes dirty folios to the end of
  2084		 * the LRU before the dirty limits are breached and the dirty
  2085		 * data has expired. It can also happen when the proportion of
  2086		 * dirty folios grows not through writes but through memory
  2087		 * pressure reclaiming all the clean cache. And in some cases,
  2088		 * the flushers simply cannot keep up with the allocation
  2089		 * rate. Nudge the flusher threads in case they are asleep.
  2090		 */
  2091		if (stat.nr_unqueued_dirty == nr_taken) {
  2092			wakeup_flusher_threads(WB_REASON_VMSCAN);
  2093			/*
  2094			 * For cgroupv1 dirty throttling is achieved by waking up
  2095			 * the kernel flusher here and later waiting on folios
  2096			 * which are in writeback to finish (see shrink_folio_list()).
  2097			 *
  2098			 * Flusher may not be able to issue writeback quickly
  2099			 * enough for cgroupv1 writeback throttling to work
  2100			 * on a large system.
  2101			 */
  2102			if (!writeback_throttling_sane(sc))
  2103				reclaim_throttle(pgdat, VMSCAN_THROTTLE_WRITEBACK);
  2104		}
  2105	
  2106		sc->nr.dirty += stat.nr_dirty;
  2107		sc->nr.congested += stat.nr_congested;
  2108		sc->nr.unqueued_dirty += stat.nr_unqueued_dirty;
  2109		sc->nr.writeback += stat.nr_writeback;
  2110		sc->nr.immediate += stat.nr_immediate;
  2111		sc->nr.taken += nr_taken;
  2112		if (file)
  2113			sc->nr.file_taken += nr_taken;
  2114	
  2115		trace_mm_vmscan_lru_shrink_inactive(pgdat->node_id,
  2116				nr_scanned, nr_reclaimed, &stat, sc->priority, file);
  2117		return nr_reclaimed;
  2118	}
  2119	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki