Re: [PATCH rdma-next v1 5/8] RDMA/core: Introduce a DMAH object and its alloc/free APIs

[Jason Gunthorpe <jgg@nvidia.com>]

On Sun, Jul 13, 2025 at 09:37:26AM +0300, Leon Romanovsky wrote:
> +static int UVERBS_HANDLER(UVERBS_METHOD_DMAH_ALLOC)(
> +	struct uverbs_attr_bundle *attrs)
> +{
> +	struct ib_uobject *uobj =
> +		uverbs_attr_get(attrs, UVERBS_ATTR_ALLOC_DMAH_HANDLE)
> +			->obj_attr.uobject;
> +	struct ib_device *ib_dev = attrs->context->device;
> +	struct ib_dmah *dmah;
> +	int ret;
> +
> +	if (!ib_dev->ops.alloc_dmah || !ib_dev->ops.dealloc_dmah)
> +		return -EOPNOTSUPP;

This shouldn't be needed, use UAPI_DEF_OBJ_NEEDS_FN() instead.
> +DECLARE_UVERBS_NAMED_OBJECT(UVERBS_OBJECT_DMAH,
> +			    UVERBS_TYPE_ALLOC_IDR(uverbs_free_dmah),
> +			    &UVERBS_METHOD(UVERBS_METHOD_DMAH_ALLOC),
> +			    &UVERBS_METHOD(UVERBS_METHOD_DMAH_FREE));
> +
> +const struct uapi_definition uverbs_def_obj_dmah[] = {
> +	UAPI_DEF_CHAIN_OBJ_TREE_NAMED(UVERBS_OBJECT_DMAH,
> +				      UAPI_DEF_OBJ_NEEDS_FN(dealloc_dmah)),
> +	{}

I think it should be on the NAMED_OBJECT in this case, like AH:

	DECLARE_UVERBS_OBJECT(
		UVERBS_OBJECT_AH,
[..]
		UAPI_DEF_OBJ_NEEDS_FN(create_user_ah),
		UAPI_DEF_OBJ_NEEDS_FN(destroy_ah)),

Jason