From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Neal Cardwell <ncardwell@google.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 1/8] tcp: do not accept packets beyond window
Date: Mon, 14 Jul 2025 18:38:09 -0700 [thread overview]
Message-ID: <20250714183809.02ed2853@kernel.org> (raw)
In-Reply-To: <20250711114006.480026-2-edumazet@google.com>
On Fri, 11 Jul 2025 11:39:59 +0000 Eric Dumazet wrote:
> - /** @SKB_DROP_REASON_TCP_INVALID_SEQUENCE: Not acceptable SEQ field */
> + /** @SKB_DROP_REASON_TCP_INVALID_SEQUENCE: Not acceptable SEQ field.
> + */
> SKB_DROP_REASON_TCP_INVALID_SEQUENCE,
> + /** @SKB_DROP_REASON_TCP_INVALID_END_SEQUENCE: Not acceptable END_SEQ field.
> + */
> + SKB_DROP_REASON_TCP_INVALID_END_SEQUENCE,
FWIW this is not valid kdoc. We can either do:
/** @WORDS: bla bla bla */
or
/**
* @WORDS: bla bla bla
*/
but "networking inspired style":
/** @WORDS: bla bla bla
*/
is not allowed.
Ima fix for you when applying.
next prev parent reply other threads:[~2025-07-15 1:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 11:39 [PATCH net-next 0/8] tcp: receiver changes Eric Dumazet
2025-07-11 11:39 ` [PATCH net-next 1/8] tcp: do not accept packets beyond window Eric Dumazet
2025-07-12 20:52 ` Kuniyuki Iwashima
2025-07-15 1:38 ` Jakub Kicinski [this message]
2025-07-11 11:40 ` [PATCH net-next 2/8] tcp: add LINUX_MIB_BEYOND_WINDOW Eric Dumazet
2025-07-12 20:55 ` Kuniyuki Iwashima
2025-07-11 11:40 ` [PATCH net-next 3/8] selftests/net: packetdrill: add tcp_rcv_big_endseq.pkt Eric Dumazet
2025-07-12 20:58 ` Kuniyuki Iwashima
2025-07-11 11:40 ` [PATCH net-next 4/8] tcp: call tcp_measure_rcv_mss() for ooo packets Eric Dumazet
2025-07-12 21:11 ` Kuniyuki Iwashima
2025-07-11 11:40 ` [PATCH net-next 5/8] selftests/net: packetdrill: add tcp_ooo_rcv_mss.pkt Eric Dumazet
2025-07-12 21:42 ` Kuniyuki Iwashima
2025-07-11 11:40 ` [PATCH net-next 6/8] tcp: add const to tcp_try_rmem_schedule() and sk_rmem_schedule() skb Eric Dumazet
2025-07-12 21:43 ` Kuniyuki Iwashima
2025-07-11 11:40 ` [PATCH net-next 7/8] tcp: stronger sk_rcvbuf checks Eric Dumazet
2025-07-12 21:54 ` Kuniyuki Iwashima
2025-12-15 10:19 ` Christian Ebner
2025-12-18 9:31 ` Christian Ebner
2025-12-18 10:10 ` Eric Dumazet
2025-12-18 12:28 ` Christian Ebner
2025-12-18 13:19 ` Eric Dumazet
2025-12-18 14:58 ` Christian Ebner
2025-12-19 8:23 ` Eric Dumazet
2025-12-19 8:45 ` Eric Dumazet
2025-12-19 10:00 ` Christian Ebner
2025-12-19 10:12 ` Eric Dumazet
2026-01-25 21:11 ` [regression] " Simon Baatz
2025-07-11 11:40 ` [PATCH net-next 8/8] selftests/net: packetdrill: add tcp_rcv_toobig.pkt Eric Dumazet
2025-07-12 21:57 ` Kuniyuki Iwashima
2025-07-15 2:20 ` [PATCH net-next 0/8] tcp: receiver changes patchwork-bot+netdevbpf
2025-07-15 8:25 ` Paolo Abeni
2025-07-15 9:21 ` Matthieu Baerts
2025-07-15 10:14 ` Paolo Abeni
2025-07-15 10:40 ` Matthieu Baerts
2025-07-15 13:28 ` Jakub Kicinski
2025-07-15 13:33 ` Jakub Kicinski
2025-07-15 13:52 ` Paolo Abeni
2025-07-15 14:54 ` Jakub Kicinski
2025-07-15 14:48 ` Kuniyuki Iwashima
2025-07-15 13:50 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714183809.02ed2853@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.