From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08D50C83F17 for ; Mon, 14 Jul 2025 23:56:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubT2L-0002Nl-GW; Mon, 14 Jul 2025 19:56:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubT2J-0002CL-1r for qemu-arm@nongnu.org; Mon, 14 Jul 2025 19:56:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubT2G-0007Qx-F4 for qemu-arm@nongnu.org; Mon, 14 Jul 2025 19:56:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752537399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yyynhVn6YIjdDDiSm17bBMgB3kqi/YfOvitQmZpGTmU=; b=AE6wIEjUjS/kSYa3g0vtUH86MMVIm0ARIqhbJ+DioD1mNlHDdgIoB+bdDob+/156xwkve4 tOUwuQjltq6nGdP1sTudb+aMpdGq6aGk5iFobiBgDQwpp7ZPbzUYruJ2rXl0Sf5ohMaBrn 9UaAxjTlNg+D6xP+Rn/vhtI+T3B1mz0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-kofH0GpHNpakif6EItmnmQ-1; Mon, 14 Jul 2025 19:56:36 -0400 X-MC-Unique: kofH0GpHNpakif6EItmnmQ-1 X-Mimecast-MFC-AGG-ID: kofH0GpHNpakif6EItmnmQ_1752537395 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4eb6fcd88so3158314f8f.1 for ; Mon, 14 Jul 2025 16:56:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752537395; x=1753142195; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yyynhVn6YIjdDDiSm17bBMgB3kqi/YfOvitQmZpGTmU=; b=py9q0rXDxFTVOc32TzDJrBDDz1bpvp33dwIiqGXZl0kfdPeehgqHpUmDgiCPdhjV8T /9A6+7y9Hyo89o8fxh9scbJpl3kGez6gqaGl1IL0B5ASEP/U0FaOujH3LSAX0xtPjpSv Oe0yz93oOlCZW/K7KNAn18UjVFqoeGi+3zSSaSflljQvZO8iVlDGZg5eYQMHjbyrm7vb mHQPrlFw73gmh2lB/0nLxP6W+nfufSQxIQVtqSrvu/97WY5KdEkmUuYhpJZHhzwImBlM I4+l83CjlTOFcDE5W1sfwHlYIhZ141U9GPZ4LoAKjcCJFTJ/nmkbiPuWuFgRaYcAj9uc GDsg== X-Forwarded-Encrypted: i=1; AJvYcCX61TKkFk5gLja6keSIAD/DifVFxrwc/vNzcSECzq4Duc2rl7P/EiPxdBQbQriorbLJc/WISjerHQ==@nongnu.org X-Gm-Message-State: AOJu0Yx5DPzRk3XkUhkw345BxEXtu/a5ea14enB5J+CttTNkbLK6kz4y x+ZBB4MhqaB2BvaZ8eQpH5A+7OkJR6yWbaaZF0Ve6XYNh/QhSpDXMe+CAzvCCenhsXnUXpKgmQL R6dfUr/SUCWd0P1D3000HSmkHCu3YV45RZ582b85a9F902BnOtsGLpQ== X-Gm-Gg: ASbGncuaweagKr8EleHz1t44x1TGTjkCO6PIB5WI6CjZez7d5EfLj3weOsg49WtW/Hm QHujCnmZ2bUneK+1lNUhr0FZwS34t5eucqSqUboCbR6MdR+MJaJvS+jd2e1yYAvJTZIHBTbrtGm H8T+uJFI3/4/thowxFwoq6YPlCKcBYg8RLNzw5HadVpKlWShRyJVWB/EuoK2VVG8Hq0VqMGKTMk jJl1rmc2+Fkm8dc+Sj1I1ElX/2i/P0TJcCs3OXqcI7h544r7Ia7roNFNMPDFj8+r/vCIT4fD5JZ kHh41e8uoYFkLOLy0OLBp6Cf+AA7cg/9 X-Received: by 2002:a05:6000:2f81:b0:3a3:7baf:f06a with SMTP id ffacd0b85a97d-3b5f2dfdd45mr11282396f8f.37.1752537395130; Mon, 14 Jul 2025 16:56:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGiBWNPMogNMuw+FGLG9uPDQP65NspuydWNxXlVDgLEvdReYYcZYDkRStd2nFXJToEPKtfBtg== X-Received: by 2002:a05:6000:2f81:b0:3a3:7baf:f06a with SMTP id ffacd0b85a97d-3b5f2dfdd45mr11282379f8f.37.1752537394664; Mon, 14 Jul 2025 16:56:34 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:150d:fc00:de3:4725:47c6:6809]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0d785sm13905370f8f.59.2025.07.14.16.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 16:56:33 -0700 (PDT) Date: Mon, 14 Jul 2025 19:56:30 -0400 From: "Michael S. Tsirkin" To: Eric Auger Cc: Jonathan Cameron , eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, imammedo@redhat.com, gustavo.romero@linaro.org, anisinha@redhat.com, shannon.zhaosl@gmail.com, pbonzini@redhat.com, philmd@linaro.org, alex.bennee@linaro.org, alireza.sanaee@huawei.com Subject: Re: [PATCH v7 00/36] ACPI PCI Hotplug support on ARM Message-ID: <20250714195616-mutt-send-email-mst@kernel.org> References: <20250714080639.2525563-1-eric.auger@redhat.com> <20250714204008.00003fba@huawei.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: llZRrZyLggcbQHGij5ld8uSzMh1u95oNdvNNfjkQbNA_1752537395 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Mon, Jul 14, 2025 at 09:51:40PM +0200, Eric Auger wrote: > Hi Jonathan, > > On 7/14/25 9:40 PM, Jonathan Cameron wrote: > > On Mon, 14 Jul 2025 10:04:44 +0200 > > Eric Auger wrote: > > > >> This series enables ACPI PCI hotplug/hotunplug on ARM. > >> It is not enabled by default and ACPI PCI hotplug can > >> be selected by setting: > >> > >> -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > >> > >> Expected benefits should be similar to those listed in [1], > >> ie. removal of some racy behaviors, improved latencies. > >> > >> The infrastructure used in x86 is heavily reused and a > >> huge part of the series consists in moving code from > >> hw/i386/acpi-build.c to a generic place and slightly > >> adapting it to make it usable on ARM. The DSDT table is > >> augmented to support ACPI PCI hotplug elements. > >> > >> On ARM we use use a GED event to notify the OS about > >> hotplug events. > >> > >> Best Regards > >> > >> Eric > > Hi Eric, > > > > I guess you probably already know this but there is some > > impact on loongarch64 when their ACPI tables tests are added. > > > > Rather oddly I'm getting intermittent failures on Michael's > > gitlab tree but looks like the unification of _OSC affects > > them as well. (should be every time, but they aren't!) > > > > Should just be updating their 4 DSDT variants. > > > > If I had a stable test setup I'd send them. Will try again > > tomorrow if not resolved. > just to make sure are we talking about > > [PATCH v3 0/5] Add bios-tables-test for LoongArch system > https://lore.kernel.org/all/20250612090321.3416594-2-maobibo@loongson.cn/ > > Thanks > > Eric I fixed this up, don't worry. > > > > > > Jonathan > > > > > > > >> This series can be found at: > >> https://github.com/eauger/qemu/tree/arm-acpi-pcihp-v7 > >> > >> previous series: > >> https://github.com/eauger/qemu/tree/arm-acpi-pcihp-v6 > >> > >> History: > >> v6 -> v7: > >> - rebased after minor contextual conflict introduced > >> by "hw/arm/virt: Basic CXL enablement on pci_expander_bridge > >> instances pxb-cxl" in hw/arm/virt-acpi-build.c > >> (hw/pci-host/gpex-acpi: Use GED acpi pcihp property) > >> - collected last Igor's and Prasad's R-bs > >> > >> v5 -> v6: > >> - collected Jonathan's R-bs > >> - cropped last 2 patch commit messages (Jonathan) > >> > >> v4 -> v5: > >> - Collected Jonathan's R-bs (many thanks!) > >> - fixed the tests/qtest/bios-tables-test issue by > >> creating a variant for the viot test > >> - use the 3 phase reset API > >> - fixed qom-test failures that were due to unconditionnal > >> fetches of the GED property > >> > >> v3 -> v4: > >> - toook into account all comments on v3 > >> - static acpi-index is now supported unconditionally > >> from acpi pcihp option. See indiviual patches. > >> - I hit a problem with ref block generation at > >> [19/32] tests/qtest/bios-tables-test: Update ARM DSDT reference > >> blobs: despite I regenerate the blobs, I get some errors. > >> > >> v2 -> v3: > >> - lot of changes taking into account various feedbacks > >> (many thanks to all reviewers). Please refer to > >> individual patches for details. Main changes: > >> - no more machine option, acpi pci hp is not set by > >> default. > >> - removal of 2 unused variables in the osc method > >> - introduction of GED property to set the bus > >> - rework of the init/reset sequence > >> - fix virtio-mem-pci hotplug regression > >> > >> v1 -> v2: > >> - collected a bunch of R-bs from Gustavo (many thanks!) > >> - Fixed the breakage of bios-tables-test in TCG mode by > >> incorporating Gustavo's patches (part of > >> [PATCH 0/5] ACPI tests for PCI Hotplug on ARM > >> https://lore.kernel.org/all/20250526053123.1434204-1-gustavo.romero@linaro.org/) > >> - Tweeked the dsdt aml changes to avoid any dsdt blob difference when > >> acpi-pcihp is off. > >> > >> RFC -> v1: > >> - First 3 trivial patches were pulled separately > >> - Fix of the register region size (0x18), ie. ACPI_PCIHP_SIZE > >> - addition of aml_pci_edsm which was not called in RFC > >> - acpi-index feature is now fixed. vms->bus was not set on > >> acpi_pcihp_init. The init sequence is still hacky though. Suggestions > >> are welcome. > >> > >> [1] [PATCH v6 0/6] Use ACPI PCI hot-plug for Q35 > >> https://lore.kernel.org/all/20210713004205.775386-1-jusual@redhat.com/ > >> > >> Eric Auger (32): > >> hw/i386/acpi-build: Make aml_pci_device_dsm() static > >> hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp > >> hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to > >> acpi_dsdt_add_pci_osc > >> hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation > >> hw/acpi/ged: Add a acpi-pci-hotplug-with-bridge-support property > >> hw/pci-host/gpex-acpi: Use GED acpi pcihp property > >> hw/i386/acpi-build: Turn build_q35_osc_method into a generic method > >> hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method > >> tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change > >> hw/i386/acpi-build: Introduce build_append_pcihp_resources() helper > >> hw/acpi/pcihp: Add an AmlRegionSpace arg to build_acpi_pci_hotplug > >> hw/i386/acpi-build: Move build_append_notification_callback to pcihp > >> hw/i386/acpi-build: Move build_append_pci_bus_devices/pcihp_slots to > >> pcihp > >> hw/i386/acpi-build: Use AcpiPciHpState::root in acpi_set_pci_info > >> hw/i386/acpi-build: Move aml_pci_edsm to a generic place > >> qtest/bios-tables-test: Prepare for fixing the aarch64 viot test > >> qtest/bios-tables-test: Add a variant to the aarch64 viot test > >> qtest/bios-tables-test: Generate DSDT.viot > >> hw/arm/virt-acpi-build: Let non hotplug ports support static > >> acpi-index > >> tests/qtest/bios-tables-test: Update ARM DSDT reference blobs > >> hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI > >> hotplug > >> hw/acpi/ged: Add a bus link property > >> hw/arm/virt: Pass the bus on the ged creation > >> hw/acpi/ged: Call pcihp plug callbacks in hotplug handler > >> implementation > >> hw/acpi/pcihp: Remove root arg in acpi_pcihp_init > >> hw/acpi/ged: Prepare the device to react to PCI hotplug events > >> hw/acpi/ged: Support migration of AcpiPciHpState > >> hw/core/sysbus: Introduce sysbus_mmio_map_name() helper > >> hw/arm/virt: Minor code reshuffling in create_acpi_ged > >> hw/arm/virt: Let virt support pci hotplug/unplug GED event > >> qtest/bios-tables-test: Generate reference blob for > >> DSDT.hpoffacpiindex > >> qtest/bios-tables-test: Generate reference blob for DSDT.acpipcihp > >> > >> Gustavo Romero (4): > >> tests/qtest/bios-tables-test: Prepare for changes in the DSDT table > >> tests/qtest/bios-tables-test: Prepare for changes in the arm virt DSDT > >> table > >> tests/qtest/bios-tables-test: Prepare for addition of acpi pci hp > >> tests > >> tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test > >> > >> hw/i386/acpi-build.h | 4 - > >> include/hw/acpi/generic_event_device.h | 17 +- > >> include/hw/acpi/pci.h | 5 +- > >> include/hw/acpi/pcihp.h | 17 +- > >> include/hw/arm/virt.h | 1 + > >> include/hw/pci-host/gpex.h | 1 + > >> include/hw/sysbus.h | 1 + > >> hw/acpi/acpi-pci-hotplug-stub.c | 2 +- > >> hw/acpi/generic_event_device.c | 77 +++ > >> hw/acpi/ich9.c | 7 +- > >> hw/acpi/pci-bridge.c | 54 ++ > >> hw/acpi/pci.c | 50 ++ > >> hw/acpi/pcihp.c | 439 ++++++++++++++- > >> hw/acpi/piix4.c | 5 +- > >> hw/arm/virt-acpi-build.c | 38 ++ > >> hw/arm/virt.c | 27 +- > >> hw/core/sysbus.c | 11 + > >> hw/i386/acpi-build.c | 532 +----------------- > >> hw/pci-host/gpex-acpi.c | 74 +-- > >> tests/qtest/bios-tables-test.c | 53 ++ > >> hw/arm/Kconfig | 2 + > >> hw/pci-host/Kconfig | 1 + > >> tests/data/acpi/aarch64/virt/DSDT | Bin 5196 -> 5293 bytes > >> .../data/acpi/aarch64/virt/DSDT.acpihmatvirt | Bin 5282 -> 5379 bytes > >> tests/data/acpi/aarch64/virt/DSDT.acpipcihp | Bin 0 -> 6202 bytes > >> .../acpi/aarch64/virt/DSDT.hpoffacpiindex | Bin 0 -> 5347 bytes > >> tests/data/acpi/aarch64/virt/DSDT.memhp | Bin 6557 -> 6654 bytes > >> tests/data/acpi/aarch64/virt/DSDT.pxb | Bin 7679 -> 7768 bytes > >> tests/data/acpi/aarch64/virt/DSDT.topology | Bin 5398 -> 5495 bytes > >> tests/data/acpi/aarch64/virt/DSDT.viot | Bin 0 -> 5310 bytes > >> tests/data/acpi/riscv64/virt/DSDT | Bin 3576 -> 3538 bytes > >> tests/data/acpi/x86/microvm/DSDT.pcie | Bin 3023 -> 2985 bytes > >> 32 files changed, 811 insertions(+), 607 deletions(-) > >> create mode 100644 tests/data/acpi/aarch64/virt/DSDT.acpipcihp > >> create mode 100644 tests/data/acpi/aarch64/virt/DSDT.hpoffacpiindex > >> create mode 100644 tests/data/acpi/aarch64/virt/DSDT.viot > >>