All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
	Anton Khirnov <anton@khirnov.net>, Takashi Iwai <tiwai@suse.de>,
	Sasha Levin <sashal@kernel.org>,
	kailang@realtek.com, sbinding@opensource.cirrus.com,
	chris.chiu@canonical.com, simont@opensource.cirrus.com,
	josh@joshuagrisham.com
Subject: [PATCH AUTOSEL 6.15 14/15] ALSA: hda/realtek: Add quirk for ASUS ExpertBook B9403CVAR
Date: Mon, 14 Jul 2025 19:06:15 -0400	[thread overview]
Message-ID: <20250714230616.3709521-14-sashal@kernel.org> (raw)
In-Reply-To: <20250714230616.3709521-1-sashal@kernel.org>

From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

[ Upstream commit db98ee56851061082fecd7e6b4b6a93600562ec2 ]

ASUS ExpertBook B9403CVAR needs the ALC294_FIXUP_ASUS_HPE for the
headphones to work.

Closes: https://github.com/thesofproject/linux/issues/5472
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Tested-by: Anton Khirnov <anton@khirnov.net>
Link: https://patch.msgid.link/20250701133411.25275-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

Based on my analysis of the commit message and code changes:

**YES** - This commit should be backported to stable kernel trees.

## Extensive Explanation:

### 1. **Nature of the Fix**
This commit adds a hardware quirk for the ASUS ExpertBook B9403CVAR
laptop to fix non-functional headphones. The change is:
```c
+       SND_PCI_QUIRK(0x1043, 0x1e93, "ASUS ExpertBook B9403CVAR",
ALC294_FIXUP_ASUS_HPE),
```

This is a simple one-line addition to the quirk table that enables the
`ALC294_FIXUP_ASUS_HPE` fixup for this specific laptop model (vendor ID
0x1043, device ID 0x1e93).

### 2. **Matches Stable Tree Criteria**
- **Fixes a real bug**: The commit explicitly states "for the headphones
  to work", indicating that without this quirk, headphones don't
  function on this laptop model
- **Small and contained**: It's a single-line addition to a quirk table
  with no architectural changes
- **Hardware enablement**: This type of fix enables basic functionality
  (audio output) on existing hardware
- **No new features**: Simply applies an existing fixup to a new
  hardware variant
- **Minimal regression risk**: The change only affects systems with this
  specific PCI ID combination

### 3. **Similar to Historical Backports**
The commit follows the exact same pattern as the similar commits
provided with "Backport Status: YES":
- All are simple quirk additions for ASUS laptops
- All use existing fixup methods (CS35L41, ALC294_FIXUP_ASUS_HPE, etc.)
- All address audio functionality issues
- All have explicit stable tags or were backported

### 4. **User Impact**
- **Without the fix**: Users of ASUS ExpertBook B9403CVAR laptops cannot
  use headphones
- **With the fix**: Basic audio functionality is restored
- The bug report reference
  (https://github.com/thesofproject/linux/issues/5472) indicates this
  was a user-reported issue affecting real systems

### 5. **Code Safety**
- Uses an existing, well-tested fixup (`ALC294_FIXUP_ASUS_HPE`)
- Placed correctly in numerical order in the quirk table
- No possibility of affecting other hardware models due to specific PCI
  ID matching
- The fixup itself only adjusts EAPD settings and chains to headset
  microphone fixes

### 6. **Comparison with Similar Commits**
All the provided similar commits with "Backport Status: YES" share these
characteristics:
- Single or few line additions to quirk tables
- Fix audio issues on specific ASUS laptop models
- Use existing fixup infrastructure
- Have clear user impact (non-functional audio components)

This commit matches all these characteristics perfectly, making it an
ideal candidate for stable backporting.

The commit represents exactly the type of hardware enablement fix that
stable trees are meant to include - it restores basic functionality on
existing hardware without introducing any new features or architectural
changes.

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 03ffaec49998d..f21f820050e42 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11011,6 +11011,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x1e63, "ASUS H7606W", ALC285_FIXUP_ASUS_GU605_SPI_SPEAKER2_TO_DAC1),
 	SND_PCI_QUIRK(0x1043, 0x1e83, "ASUS GA605W", ALC285_FIXUP_ASUS_GU605_SPI_SPEAKER2_TO_DAC1),
 	SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401),
+	SND_PCI_QUIRK(0x1043, 0x1e93, "ASUS ExpertBook B9403CVAR", ALC294_FIXUP_ASUS_HPE),
 	SND_PCI_QUIRK(0x1043, 0x1eb3, "ASUS Ally RCLA72", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x1043, 0x1ed3, "ASUS HN7306W", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x1043, 0x1ee2, "ASUS UM6702RA/RC", ALC287_FIXUP_CS35L41_I2C_2),
-- 
2.39.5


  parent reply	other threads:[~2025-07-14 23:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14 23:06 [PATCH AUTOSEL 6.15 01/15] wifi: mac80211: always initialize sdata::key_list Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 02/15] net/sched: sch_qfq: Fix null-deref in agg_dequeue Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 03/15] erofs: allow readdir() to be interrupted Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 04/15] rxrpc: Fix oops due to non-existence of prealloc backlog struct Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 05/15] net: thunderx: avoid direct MTU assignment after WRITE_ONCE() Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 06/15] eventpoll: don't decrement ep refcount while still holding the ep mutex Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 07/15] gpio: of: initialize local variable passed to the .of_xlate() callback Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 08/15] perf/core: Fix WARN in perf_sigtrap() Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 09/15] ksmbd: fix potential use-after-free in oplock/lease break ack Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 10/15] wifi: mt76: fix queue assignment for deauth packets Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 11/15] wifi: mt76: add a wrapper for wcid access with validation Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 12/15] wifi: mac80211: clear frame buffer to never leak stack Sasha Levin
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 13/15] pinctrl: aw9523: fix can_sleep flag for GPIO chip Sasha Levin
2025-07-14 23:06 ` Sasha Levin [this message]
2025-07-14 23:06 ` [PATCH AUTOSEL 6.15 15/15] ASoC: Intel: sof_sdw: Add quirks for Lenovo P1 and P16 Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250714230616.3709521-14-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=anton@khirnov.net \
    --cc=chris.chiu@canonical.com \
    --cc=josh@joshuagrisham.com \
    --cc=kailang@realtek.com \
    --cc=patches@lists.linux.dev \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=sbinding@opensource.cirrus.com \
    --cc=simont@opensource.cirrus.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.