All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trondmy@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Christoph Hellwig <hch@lst.de>, Anna Schumaker <anna@kernel.org>,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] NFS: add a clientid mount option
Date: Tue, 15 Jul 2025 07:31:14 +0200	[thread overview]
Message-ID: <20250715053114.GB17897@lst.de> (raw)
In-Reply-To: <7045a21c6fb5c98c6b86754880589ce1fc5ec049.camel@kernel.org>

On Mon, Jul 14, 2025 at 08:49:51AM -0700, Trond Myklebust wrote:
> There is a lot of potential for tripping over your own shoelaces with
> this mount option.
> 
> I can't think of any circumstances where an ordinary user should need
> to set a different client identifier depending on the server. I too am
> therefore sceptical that anyone will need this functionality other than
> for kernel development purposes. It requires very deep knowledge of the
> NFSv4 protocol both to understand what it does,

I agree so far.

> and to stay out of
> trouble when using it.

But I don't really see the trouble when using it, except for the fact
that no one really should use it.

But hey, I can live with this not getting merged if the use case is
too narrow, at least it can be found now if someone needs it :)


  reply	other threads:[~2025-07-15  5:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14  6:30 add a clientid mount option Christoph Hellwig
2025-07-14  6:30 ` [PATCH 1/2] NFS: pass struct nfs_client_initdata to nfs4_set_client Christoph Hellwig
2025-07-14 15:51   ` Trond Myklebust
2025-07-14  6:30 ` [PATCH 2/2] NFS: add a clientid mount option Christoph Hellwig
2025-07-14 13:24   ` Chuck Lever
2025-07-14 13:31     ` Christoph Hellwig
2025-07-14 14:47       ` Chuck Lever
2025-07-14 15:49         ` Trond Myklebust
2025-07-15  5:31           ` Christoph Hellwig [this message]
2025-07-15  5:30         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715053114.GB17897@lst.de \
    --to=hch@lst.de \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.