All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Nitesh Shetty <nj.shetty@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	gost.dev@samsung.com, nitheshshetty@gmail.com,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmet: Add support for FDP devices in fabrics passthru path
Date: Tue, 15 Jul 2025 10:09:58 +0200	[thread overview]
Message-ID: <20250715080958.GA20790@lst.de> (raw)
In-Reply-To: <20250715061804.1954522-1-nj.shetty@samsung.com>

On Tue, Jul 15, 2025 at 11:48:04AM +0530, Nitesh Shetty wrote:
> In nvmet passthru path FDP is disabled, because of failure of
> admin_get_features FDP(0x1d) feature command.
> Supporting this through nvmet_setup_passthru_command enables FDP.

I don't think this is safe - the feature has endurance group scope
and thus can affect other controllers not passed through as well.



  reply	other threads:[~2025-07-15  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250715061856epcas5p196a0b67fe58b71e1f81f98a903e429c0@epcas5p1.samsung.com>
2025-07-15  6:18 ` [PATCH] nvmet: Add support for FDP devices in fabrics passthru path Nitesh Shetty
2025-07-15  8:09   ` Christoph Hellwig [this message]
2025-07-16  8:43     ` Nitesh Shetty
2025-07-16 11:24       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715080958.GA20790@lst.de \
    --to=hch@lst.de \
    --cc=gost.dev@samsung.com \
    --cc=kch@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nitheshshetty@gmail.com \
    --cc=nj.shetty@samsung.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.