From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F86BA42; Tue, 15 Jul 2025 13:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586295; cv=none; b=ukCtBeHy/aT6VviThpXuG0LrP7ItD2h7bSsKgAv/0J/NRhv7+vx1JG6xDmMUh573vhsX/74HHk8t8oo+fzETZQGj7EEa1LHQx7dfBEjBPvm1ezbCZ+dSrlMe225OkXmyNPrU9vuKNPGv+u2FAcWgefgSSemvgZ4hllHlGyaebcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586295; c=relaxed/simple; bh=sRz26X6n9vdSR7Oj2TrMs50xPchMyNDREwODfETaTGc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Smjh/p5VIOEM0rZcTRVo39NZdDxs1IiP8sDfKBKBOeZ5FbRQBPqkDOxBCcf1dEj5ps0S5omeCiEiKWrP/VsA5lM/Wlp6+7MeZOITGQSszcpsjQ05VtL4Jxf/7VKW5XQzeKWkQbJkhMk3GHcmSbd8FS0P5/qHUk99HFYONe+V0pY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Gz33NQZn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Gz33NQZn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB695C4CEE3; Tue, 15 Jul 2025 13:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752586295; bh=sRz26X6n9vdSR7Oj2TrMs50xPchMyNDREwODfETaTGc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gz33NQZnRrrilhnVffiOLPiFewnsu86igzCg8fwZEUsbgGmNUy55BY3PxTjsopgKz FK3YBUezdfIpb2fAVKG893Q3149l8VDoLnmBNpjXb+o3gNjIkpXvhi+vc5C12uLnXv TDzsq+eHvqGFEZDbaVUnp1VbTDpl/d3AIQvcdZiE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= , Cezary Rojewski , Takashi Iwai , Sasha Levin Subject: [PATCH 5.4 012/148] ALSA: hda: Ignore unsol events for cards being shut down Date: Tue, 15 Jul 2025 15:12:14 +0200 Message-ID: <20250715130800.795516178@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130800.293690950@linuxfoundation.org> References: <20250715130800.293690950@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cezary Rojewski [ Upstream commit 3f100f524e75586537e337b34d18c8d604b398e7 ] For the classic snd_hda_intel driver, codec->card and bus->card point to the exact same thing. When snd_card_diconnect() fires, bus->shutdown is set thanks to azx_dev_disconnect(). card->shutdown is already set when that happens but both provide basically the same functionality. For the DSP snd_soc_avs driver where multiple codecs are located on multiple cards, bus->shutdown 'shortcut' is not sufficient. One codec card may be unregistered while other codecs are still operational. Proper check in form of card->shutdown must be used to verify whether the codec's card is being shut down. Reviewed-by: Amadeusz Sławiński Signed-off-by: Cezary Rojewski Link: https://patch.msgid.link/20250530141309.2943404-1-cezary.rojewski@intel.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/hda_bind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_bind.c b/sound/pci/hda/hda_bind.c index 17a25e453f60c..047fe6cca7f1a 100644 --- a/sound/pci/hda/hda_bind.c +++ b/sound/pci/hda/hda_bind.c @@ -44,7 +44,7 @@ static void hda_codec_unsol_event(struct hdac_device *dev, unsigned int ev) struct hda_codec *codec = container_of(dev, struct hda_codec, core); /* ignore unsol events during shutdown */ - if (codec->bus->shutdown) + if (codec->card->shutdown || codec->bus->shutdown) return; /* ignore unsol events during system suspend/resume */ -- 2.39.5