From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E5A23ABAF; Tue, 15 Jul 2025 13:33:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586414; cv=none; b=YlROnNoUXDAs1cgOToMlbT5Lto8Km1CrZyHkWrYhj1CuCITsUvmlkSsqk8h6pmvlilh3PFp6dE502V9tE8D3F7UXm9mdDo8jRZ4StzpMBkI4w/4ppgt9YOncSMyPwnpD3utHTtqlkaBtmKQFMVzgMPfpEEf/KcXL0tJ5XdzBMpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586414; c=relaxed/simple; bh=A0n45aCAYENGKTPc0rVKpxjNVt2sDNmDLFNX44jv9NU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LwLcXst5T+RkmxDGvdRquELtB1oPOa7Z93VdMGLPVEtIql0+fj93V8/F24ZtYH7JlFpOFO14yHFsvnl2Wis3ExTBYxFX9CYyRMpqBoRCrLj7OdWbFXiMsRmf5zL68nQw53gC8IBgSnVuXT+vyy85ib1/Gc5I1rOT8jJgiPe8GkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HT++DPDA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HT++DPDA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EEFEC4CEE3; Tue, 15 Jul 2025 13:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752586414; bh=A0n45aCAYENGKTPc0rVKpxjNVt2sDNmDLFNX44jv9NU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HT++DPDAdOpUA0mrp3JJZl9qkGRHaJhlcVlyUMiZRdYrXm8iILJ7uPYTTFQsMX4k1 42X9UG8pCrpScs415t5+bT45q1zhoxYrDuw6D4qn6eFgvFGkVRVsRUw9EdU192swEM Y9/zH9qeRkR4J9TgwiAO5JRwWoJflayD3Ah3SMyQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bryan Tan , Vishnu Dasa , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , virtualization@lists.linux.dev, netdev@vger.kernel.org, stable , HarshaVardhana S A Subject: [PATCH 5.4 056/148] vsock/vmci: Clear the vmci transport packet properly when initializing it Date: Tue, 15 Jul 2025 15:12:58 +0200 Message-ID: <20250715130802.571401214@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130800.293690950@linuxfoundation.org> References: <20250715130800.293690950@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: HarshaVardhana S A commit 223e2288f4b8c262a864e2c03964ffac91744cd5 upstream. In vmci_transport_packet_init memset the vmci_transport_packet before populating the fields to avoid any uninitialised data being left in the structure. Cc: Bryan Tan Cc: Vishnu Dasa Cc: Broadcom internal kernel review list Cc: Stefano Garzarella Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Simon Horman Cc: virtualization@lists.linux.dev Cc: netdev@vger.kernel.org Cc: stable Signed-off-by: HarshaVardhana S A Signed-off-by: Greg Kroah-Hartman Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Acked-by: Stefano Garzarella Link: https://patch.msgid.link/20250701122254.2397440-1-gregkh@linuxfoundation.org Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- net/vmw_vsock/vmci_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock/vmci_transport.c @@ -125,6 +125,8 @@ vmci_transport_packet_init(struct vmci_t u16 proto, struct vmci_handle handle) { + memset(pkt, 0, sizeof(*pkt)); + /* We register the stream control handler as an any cid handle so we * must always send from a source address of VMADDR_CID_ANY */ @@ -137,8 +139,6 @@ vmci_transport_packet_init(struct vmci_t pkt->type = type; pkt->src_port = src->svm_port; pkt->dst_port = dst->svm_port; - memset(&pkt->proto, 0, sizeof(pkt->proto)); - memset(&pkt->_reserved2, 0, sizeof(pkt->_reserved2)); switch (pkt->type) { case VMCI_TRANSPORT_PACKET_TYPE_INVALID: