From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914DA2DEA72; Tue, 15 Jul 2025 13:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586560; cv=none; b=ELm3pbP2D/WA58rq4E20BmOlMLHK4EMX9C8wmNJWUaQO+0gqpRbznvC8EIc8F0s8LrH3Lza2NwkVKwijyy4m0++ndBvqm5VSF4kjK/3Hpc8XmDrm66oDKvAFkMcvvYD/Naqi+ZzBqFFeTWiUybgedgPe0IVT6UmZm9BEWtuMoFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586560; c=relaxed/simple; bh=SquwxXBbskAzv65iCS6xNQaz1KcGmljvYkFGwsM9CL8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CZQTLNhKoiYAy8RZTSPHVsyoucuxazMGHO+k4W/VXcbcXggeIy4GBqVcraix66IjAA8VWdwBfsqrFfRiCLEkwt/CbUGTJ3UJI9D8875rgT4G/1tpLhJNmtk4LX/1+73oj+0UZl9eAMlK/trzaeJMz9mKGxLG7q8J4gU15noNrF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=T7Xqw6Mc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="T7Xqw6Mc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0FB7C4CEE3; Tue, 15 Jul 2025 13:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752586560; bh=SquwxXBbskAzv65iCS6xNQaz1KcGmljvYkFGwsM9CL8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T7Xqw6McVjzTtwQ2MEi8vISz5xrXIwnbMUsd1NxnQ55hK48DfY1zk+CIGUIrLG4Fa xAuhr8TyDcQ1YgStUyC5EiABi2uCK99FBBYIiBcncf18UVgK8C62OvB4KK9ih2G+5E s5L5NWyVIh6kM2h7UUmhXTUgK5gCuNkC/7qj7uYY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kuniyuki Iwashima , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 112/148] atm: clip: Fix memory leak of struct clip_vcc. Date: Tue, 15 Jul 2025 15:13:54 +0200 Message-ID: <20250715130804.793448853@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130800.293690950@linuxfoundation.org> References: <20250715130800.293690950@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kuniyuki Iwashima [ Upstream commit 62dba28275a9a3104d4e33595c7b3328d4032d8d ] ioctl(ATMARP_MKIP) allocates struct clip_vcc and set it to vcc->user_back. The code assumes that vcc_destroy_socket() passes NULL skb to vcc->push() when the socket is close()d, and then clip_push() frees clip_vcc. However, ioctl(ATMARPD_CTRL) sets NULL to vcc->push() in atm_init_atmarp(), resulting in memory leak. Let's serialise two ioctl() by lock_sock() and check vcc->push() in atm_init_atmarp() to prevent memleak. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Kuniyuki Iwashima Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250704062416.1613927-3-kuniyu@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/atm/clip.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/atm/clip.c b/net/atm/clip.c index d5363ae5296ad..8415ac2805474 100644 --- a/net/atm/clip.c +++ b/net/atm/clip.c @@ -646,6 +646,9 @@ static struct atm_dev atmarpd_dev = { static int atm_init_atmarp(struct atm_vcc *vcc) { + if (vcc->push == clip_push) + return -EINVAL; + mutex_lock(&atmarpd_lock); if (atmarpd) { mutex_unlock(&atmarpd_lock); @@ -670,6 +673,7 @@ static int atm_init_atmarp(struct atm_vcc *vcc) static int clip_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) { struct atm_vcc *vcc = ATM_SD(sock); + struct sock *sk = sock->sk; int err = 0; switch (cmd) { @@ -690,14 +694,18 @@ static int clip_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) err = clip_create(arg); break; case ATMARPD_CTRL: + lock_sock(sk); err = atm_init_atmarp(vcc); if (!err) { sock->state = SS_CONNECTED; __module_get(THIS_MODULE); } + release_sock(sk); break; case ATMARP_MKIP: + lock_sock(sk); err = clip_mkip(vcc, arg); + release_sock(sk); break; case ATMARP_SETENTRY: err = clip_setentry(vcc, (__force __be32)arg); -- 2.39.5