From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 03/15] neighbour: Allocate skb in neigh_get().
Date: Tue, 15 Jul 2025 18:23:43 -0700 [thread overview]
Message-ID: <20250715182343.5ed6f8fc@kernel.org> (raw)
In-Reply-To: <20250712203515.4099110-4-kuniyu@google.com>
On Sat, 12 Jul 2025 20:34:12 +0000 Kuniyuki Iwashima wrote:
> + err = -ENOENT;
> + goto err;
nit: maybe name the label ? err_free_skb ?
next prev parent reply other threads:[~2025-07-16 1:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 20:34 [PATCH v2 net-next 00/15] neighbour: Convert RTM_GETNEIGH to RCU and make pneigh RTNL-free Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 01/15] neighbour: Make neigh_valid_get_req() return ndmsg Kuniyuki Iwashima
2025-07-16 1:17 ` Jakub Kicinski
2025-07-16 6:45 ` Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 02/15] neighbour: Move two validations from neigh_get() to neigh_valid_get_req() Kuniyuki Iwashima
2025-07-16 1:22 ` Jakub Kicinski
2025-07-16 6:56 ` Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 03/15] neighbour: Allocate skb in neigh_get() Kuniyuki Iwashima
2025-07-16 1:23 ` Jakub Kicinski [this message]
2025-07-16 7:01 ` Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 04/15] neighbour: Move neigh_find_table() to neigh_get() Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 05/15] neighbour: Split pneigh_lookup() Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 06/15] neighbour: Annotate neigh_table.phash_buckets and pneigh_entry.next with __rcu Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 07/15] neighbour: Free pneigh_entry after RCU grace period Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 08/15] neighbour: Annotate access to struct pneigh_entry.{flags,protocol} Kuniyuki Iwashima
2025-07-16 1:37 ` Jakub Kicinski
2025-07-16 7:02 ` Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 09/15] neighbour: Convert RTM_GETNEIGH to RCU Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 10/15] neighbour: Drop read_lock_bh(&tbl->lock) in pneigh_dump_table() Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 11/15] neighbour: Use rcu_dereference() in pneigh_get_{first,next}() Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 12/15] neighbour: Remove __pneigh_lookup() Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 13/15] neighbour: Drop read_lock_bh(&tbl->lock) in pneigh_lookup() Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 14/15] neighbour: Protect tbl->phash_buckets[] with a dedicated mutex Kuniyuki Iwashima
2025-07-12 20:34 ` [PATCH v2 net-next 15/15] neighbour: Update pneigh_entry in pneigh_create() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715182343.5ed6f8fc@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.