From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com,
shuah@kernel.org, kory.maincent@bootlin.com,
maxime.chevallier@bootlin.com, sdf@fomichev.me,
ecree.xilinx@gmail.com, gal@nvidia.com, jdamato@fastly.com,
andrew@lunn.ch, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v3 02/11] selftests: drv-net: rss_api: factor out checking min queue count
Date: Tue, 15 Jul 2025 17:03:22 -0700 [thread overview]
Message-ID: <20250716000331.1378807-3-kuba@kernel.org> (raw)
In-Reply-To: <20250716000331.1378807-1-kuba@kernel.org>
Multiple tests check min queue count, create a helper.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
| 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
--git a/tools/testing/selftests/drivers/net/hw/rss_api.py b/tools/testing/selftests/drivers/net/hw/rss_api.py
index 6ae908bed1a4..2c76fbdb2617 100755
--- a/tools/testing/selftests/drivers/net/hw/rss_api.py
+++ b/tools/testing/selftests/drivers/net/hw/rss_api.py
@@ -13,6 +13,13 @@ from lib.py import EthtoolFamily
from lib.py import NetDrvEnv
+def _require_2qs(cfg):
+ qcnt = len(glob.glob(f"/sys/class/net/{cfg.ifname}/queues/rx-*"))
+ if qcnt < 2:
+ raise KsftSkipEx(f"Local has only {qcnt} queues")
+ return qcnt
+
+
def _ethtool_create(cfg, act, opts):
output = ethtool(f"{act} {cfg.ifname} {opts}").stdout
# Output will be something like: "New RSS context is 1" or
@@ -57,10 +64,7 @@ from lib.py import NetDrvEnv
Check that Netlink notifications are generated when RSS indirection
table was modified.
"""
-
- qcnt = len(glob.glob(f"/sys/class/net/{cfg.ifname}/queues/rx-*"))
- if qcnt < 2:
- raise KsftSkipEx(f"Local has only {qcnt} queues")
+ _require_2qs(cfg)
ethnl = EthtoolFamily()
ethnl.ntf_subscribe("monitor")
@@ -88,10 +92,7 @@ from lib.py import NetDrvEnv
Check that Netlink notifications are generated when RSS indirection
table was modified on an additional RSS context.
"""
-
- qcnt = len(glob.glob(f"/sys/class/net/{cfg.ifname}/queues/rx-*"))
- if qcnt < 2:
- raise KsftSkipEx(f"Local has only {qcnt} queues")
+ _require_2qs(cfg)
ctx_id = _ethtool_create(cfg, "-X", "context new")
defer(ethtool, f"-X {cfg.ifname} context {ctx_id} delete")
--
2.50.1
next prev parent reply other threads:[~2025-07-16 0:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 0:03 [PATCH net-next v3 00/11] ethtool: rss: support RSS_SET via Netlink Jakub Kicinski
2025-07-16 0:03 ` [PATCH net-next v3 01/11] ethtool: rss: initial RSS_SET (indirection table handling) Jakub Kicinski
2025-07-16 7:30 ` Gal Pressman
2025-07-16 0:03 ` Jakub Kicinski [this message]
2025-07-16 0:03 ` [PATCH net-next v3 03/11] tools: ynl: support packing binary arrays of scalars Jakub Kicinski
2025-07-16 0:03 ` [PATCH net-next v3 04/11] selftests: drv-net: rss_api: test setting indirection table via Netlink Jakub Kicinski
2025-07-16 0:03 ` [PATCH net-next v3 05/11] ethtool: rss: support setting hfunc " Jakub Kicinski
2025-07-16 0:03 ` [PATCH net-next v3 06/11] ethtool: rss: support setting hkey " Jakub Kicinski
2025-07-16 0:03 ` [PATCH net-next v3 07/11] selftests: drv-net: rss_api: test setting hashing key " Jakub Kicinski
2025-07-16 0:03 ` [PATCH net-next v3 08/11] netlink: specs: define input-xfrm enum in the spec Jakub Kicinski
2025-07-16 7:43 ` Gal Pressman
2025-07-16 0:03 ` [PATCH net-next v3 09/11] ethtool: rss: support setting input-xfrm via Netlink Jakub Kicinski
2025-07-16 0:03 ` [PATCH net-next v3 10/11] ethtool: rss: support setting flow hashing fields Jakub Kicinski
2025-07-16 7:28 ` Gal Pressman
2025-07-16 0:03 ` [PATCH net-next v3 11/11] selftests: drv-net: rss_api: test input-xfrm and hash fields Jakub Kicinski
2025-07-17 23:30 ` [PATCH net-next v3 00/11] ethtool: rss: support RSS_SET via Netlink patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716000331.1378807-3-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kory.maincent@bootlin.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.