From: "Ignacio Peña" <ignacio.pena87@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
"Ignacio Peña" <ignacio.pena87@gmail.com>
Subject: [PATCH v2 1/3] staging: sm750fb: Fix const declaration for g_fbmode array
Date: Tue, 15 Jul 2025 23:38:02 -0400 [thread overview]
Message-ID: <20250716033804.59650-2-ignacio.pena87@gmail.com> (raw)
In-Reply-To: <20250716033804.59650-1-ignacio.pena87@gmail.com>
The g_fbmode array should be declared as const pointer to const
string as its contents never change.
Signed-off-by: Ignacio Peña <ignacio.pena87@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 1d929aca3..d3bce107f 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,7 +33,7 @@
static int g_hwcursor = 1;
static int g_noaccel;
static int g_nomtrr;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char *const g_fbmode[] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview;
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-07-16 3:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 3:38 [PATCH v2 0/3] staging: sm750fb: Fix checkpatch warnings Ignacio Peña
2025-07-16 3:38 ` Ignacio Peña [this message]
2025-07-16 3:38 ` [PATCH v2 2/3] staging: sm750fb: Fix function parameter alignment Ignacio Peña
2025-07-16 3:38 ` [PATCH v2 3/3] staging: sm750fb: Fix CamelCase variable naming Ignacio Peña
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716033804.59650-2-ignacio.pena87@gmail.com \
--to=ignacio.pena87@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.