From: Jakub Kicinski <kuba@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
shuah@kernel.org, horms@kernel.org, cratiu@nvidia.com,
noren@nvidia.com, cjubran@nvidia.com, mbloch@nvidia.com,
jdamato@fastly.com, gal@nvidia.com, sdf@fomichev.me,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, nathan@kernel.org,
nick.desaulniers+lkml@gmail.com, morbo@google.com,
justinstitt@google.com, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH net-next V5 0/5] net: netdevsim: hook in XDP handling
Date: Wed, 16 Jul 2025 07:30:48 -0700 [thread overview]
Message-ID: <20250716073048.03e117a1@kernel.org> (raw)
In-Reply-To: <20250715210553.1568963-1-mohsin.bashr@gmail.com>
On Tue, 15 Jul 2025 14:05:48 -0700 Mohsin Bashir wrote:
> This patch series add tests to validate XDP native support for PASS,
> DROP, ABORT, and TX actions, as well as headroom and tailroom adjustment.
> For adjustment tests, validate support for both the extension and
> shrinking cases across various packet sizes and offset values.
>
> The pass criteria for head/tail adjustment tests require that at-least
> one adjustment value works for at-least one packet size. This ensure
> that the variability in maximum supported head/tail adjustment offset
> across different drivers is being incorporated.
>
> The results reported in this series are based on fbnic. However, the
> series is tested against multiple other drivers including netdevism.
Not much luck, on netdevsim with a debug kernel build the test seems to
time out after 3min 30sec without printing anything.
A normal VM it doesn't time out but it seems to reliably fail as follows:
TAP version 13
1..1
# timeout set to 180
# selftests: drivers/net: xdp.py
# TAP version 13
# 1..9
# ok 1 xdp.test_xdp_native_pass_sb
# ok 2 xdp.test_xdp_native_pass_mb
# ok 3 xdp.test_xdp_native_drop_sb
# ok 4 xdp.test_xdp_native_drop_mb
# ok 5 xdp.test_xdp_native_tx_mb
# # Exception| Traceback (most recent call last):
# # Exception| File "/home/virtme/testing-17/tools/testing/selftests/net/lib/py/ksft.py", line 243, in ksft_run
# # Exception| case(*args)
# # Exception| File "/home/virtme/testing-17/tools/testing/selftests/drivers/net/./xdp.py", line 466, in test_xdp_native_adjst_tail_grow_data
# # Exception| _validate_res(res, offset_lst, pkt_sz_lst)
# # Exception| File "/home/virtme/testing-17/tools/testing/selftests/drivers/net/./xdp.py", line 337, in _validate_res
# # Exception| raise KsftFailEx(f"{res['reason']}")
# # Exception| net.lib.py.ksft.KsftFailEx: Adjustment failed
# not ok 6 xdp.test_xdp_native_adjst_tail_grow_data
# ok 7 xdp.test_xdp_native_adjst_tail_shrnk_data
# # Failed run: pkt_sz 512, offset -256. Last successful run: pkt_sz 512, offset -128. Reason: Adjustment failed
# ok 8 xdp.test_xdp_native_adjst_head_grow_data
# # Exception| Traceback (most recent call last):
# # Exception| File "/home/virtme/testing-17/tools/testing/selftests/net/lib/py/ksft.py", line 243, in ksft_run
# # Exception| case(*args)
# # Exception| File "/home/virtme/testing-17/tools/testing/selftests/drivers/net/./xdp.py", line 625, in test_xdp_native_adjst_head_shrnk_data
# # Exception| _validate_res(res, offset_lst, pkt_sz_lst)
# # Exception| File "/home/virtme/testing-17/tools/testing/selftests/drivers/net/./xdp.py", line 337, in _validate_res
# # Exception| raise KsftFailEx(f"{res['reason']}")
# # Exception| net.lib.py.ksft.KsftFailEx: Data exchange failed
# not ok 9 xdp.test_xdp_native_adjst_head_shrnk_data
# # Totals: pass:7 fail:2 xfail:0 xpass:0 skip:0 error:0
not ok 1 selftests: drivers/net: xdp.py # exit=1
--
pw-bot: cr
prev parent reply other threads:[~2025-07-16 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 21:05 [PATCH net-next V5 0/5] net: netdevsim: hook in XDP handling Mohsin Bashir
2025-07-15 21:05 ` [PATCH net-next V5 1/5] " Mohsin Bashir
2025-07-15 21:05 ` [PATCH net-next V5 2/5] selftests: drv-net: Test XDP_PASS/DROP support Mohsin Bashir
2025-07-15 21:05 ` [PATCH net-next V5 3/5] selftests: drv-net: Test XDP_TX support Mohsin Bashir
2025-07-15 21:05 ` [PATCH net-next V5 4/5] selftests: drv-net: Test tail-adjustment support Mohsin Bashir
2025-07-15 21:05 ` [PATCH net-next V5 5/5] selftests: drv-net: Test head-adjustment support Mohsin Bashir
2025-07-16 14:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716073048.03e117a1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=john.fastabend@gmail.com \
--cc=justinstitt@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mbloch@nvidia.com \
--cc=mohsin.bashr@gmail.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.