From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC19FC83F1B for ; Wed, 16 Jul 2025 16:34:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uc55n-0006tk-5b; Wed, 16 Jul 2025 12:34:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uc55Q-0006aT-P4 for qemu-riscv@nongnu.org; Wed, 16 Jul 2025 12:34:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uc55L-0007DG-KP for qemu-riscv@nongnu.org; Wed, 16 Jul 2025 12:34:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752683660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lt8aj1FxR9CggnAUblYrgctpsKO75BIGUfC4DVW2fjc=; b=Y6S/rOUX9Y6pavQIqMNqL+bhQHiRyNAhHUebScdibjNSoNlCEdlbaDpsJJVhhuDesSymdK BAUhlMX+r0itxrMExoumqSB58kQubhRd/NPEvXqrp7a3MnK7G9wkD0XJEwBYw91rlXJ690 hBu0YOAsqNDKzDkViUrIWIrXuswS8pU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-jC5grsbRNhKfcTUX351M_w-1; Wed, 16 Jul 2025 12:34:19 -0400 X-MC-Unique: jC5grsbRNhKfcTUX351M_w-1 X-Mimecast-MFC-AGG-ID: jC5grsbRNhKfcTUX351M_w_1752683658 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4538a2f4212so177795e9.2 for ; Wed, 16 Jul 2025 09:34:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752683658; x=1753288458; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Lt8aj1FxR9CggnAUblYrgctpsKO75BIGUfC4DVW2fjc=; b=lbG4FntGaEvy5duaMne/R6Nx8KdF4wPjIXlRu1NA6D7/zkJ2/gReUym/SemCYXrWKn j8NBEviXGHfdFKcDIBt4Pjoc1GdZmSONhjCBN4iB/fp6KdeKz0yJjrDOS9nt7eTAoTgf 3/1dkb9c6fWmw9Vcn9Icg9VV/fIUd/pBZK493HR8soB2OgkEH+X0RCfcWV4g523bYnQe OpCGrqIdwHq6M2gOJ6MQ6dhvS9y4rWv6qhJJUvlhRdEENxaK7BpUPtNk0gXTeka+LG+O 7aU96pBtfGhxcrU5AA51hSdsWpE9q/CZvOYQsk2ZcYZ+6GhOEMrvPYvNOEaahx1pI6H/ XHCg== X-Gm-Message-State: AOJu0Yz53zC5xPviuefj7G1s8DM7IZT5BPfwaBFeNTME0fbukBs0VN9b bra29b68HgmauGhHXMStT3kNAoOwMgaVQ8E8+8qsrsTJTUxjsaPTC3k1i3Tu7TM3t7/OYEmSdcl OdKtnq9CdeHwheIH5aDr701qPMwn6/Sbwmo+zYabyi12DwEtzAgcfo4zX X-Gm-Gg: ASbGncvN3cbYh2ph2s7+uxibDYYPvecB3Xy5QmkPC1059tBOyMUyTSZJRG9cX0WHXRT Sgc4DJP5uTTO/JukDHwiNIbEcBkbu2OFdAh4Z8TV6uDfdZHSOWbgJePF8QX4hGJsOMC9ECtk9BY zKjItDlXUMMnTYia2cwq6T8j33vm1Lg/XQPDqn9j77R+hOk96bCVjhUCu0e3F2Ufy+vJxUlZ337 z1Bm9/uaGjzX9GeL4ys6zHy42/xBY7lzwXkCBXcHVyg0Guyk+9MF/c3GIc0v5DiYUlNgB6tKiQx 7Dqq9caQTZqS5Aygc/kBJGlFaUBey7Ws X-Received: by 2002:a05:600c:1c81:b0:456:161c:3d6f with SMTP id 5b1f17b1804b1-4562dfe78dfmr39852415e9.11.1752683658136; Wed, 16 Jul 2025 09:34:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEV6ARNWrC22WSly1BT7ol8d2Xlb+fz8Fhi7OSr2CfruKNlfa8xXro/g5y8RAdDjwrCM28Bzg== X-Received: by 2002:a05:600c:1c81:b0:456:161c:3d6f with SMTP id 5b1f17b1804b1-4562dfe78dfmr39852125e9.11.1752683657700; Wed, 16 Jul 2025 09:34:17 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:150d:fc00:de3:4725:47c6:6809]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8bd180fsm18165517f8f.2.2025.07.16.09.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jul 2025 09:34:17 -0700 (PDT) Date: Wed, 16 Jul 2025 12:34:14 -0400 From: "Michael S. Tsirkin" To: Sunil V L Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Igor Mammedov , Ani Sinha , Andrew Jones , Anup Patel , Atish Kumar Patra Subject: Re: [PATCH 2/3] hw/riscv/virt-acpi-build.c: Update FADT and MADT versions Message-ID: <20250716123314-mutt-send-email-mst@kernel.org> References: <20250716144140.3954431-1-sunilvl@ventanamicro.com> <20250716144140.3954431-3-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: <20250716144140.3954431-3-sunilvl@ventanamicro.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2RfAiJlFCVcziOIN_-hZBaJxOi9vuK6HmankOzO6Yns_1752683658 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Wed, Jul 16, 2025 at 08:11:39PM +0530, Sunil V L wrote: > RISC-V support is added only in ACPI 6.6. According to the ACPI 6.6 > specification, the minor version of the Fixed ACPI Description Table > (FADT) should be 6, and the Multiple APIC Description Table (MADT) > should use revision 7. So, update the RISC-V FADT and MADT to reflect > correct versions. > > Signed-off-by: Sunil V L > --- > hw/riscv/virt-acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c > index ee1416d264..d7e57cbb1f 100644 > --- a/hw/riscv/virt-acpi-build.c > +++ b/hw/riscv/virt-acpi-build.c > @@ -429,7 +429,7 @@ static void build_fadt_rev6(GArray *table_data, > { > AcpiFadtData fadt = { > .rev = 6, > - .minor_ver = 5, > + .minor_ver = 6, > .flags = 1 << ACPI_FADT_F_HW_REDUCED_ACPI, > .xdsdt_tbl_offset = &dsdt_tbl_offset, > }; > @@ -537,7 +537,7 @@ static void build_madt(GArray *table_data, > > hart_index_bits = imsic_num_bits(imsic_max_hart_per_socket); > > - AcpiTable table = { .sig = "APIC", .rev = 6, .oem_id = s->oem_id, > + AcpiTable table = { .sig = "APIC", .rev = 7, .oem_id = s->oem_id, > .oem_table_id = s->oem_table_id }; Add comments citing the spec version and chapter. > acpi_table_begin(&table, table_data); > -- > 2.43.0