From: "Ignacio Peña" <ignacio.pena87@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev
Cc: Ignacio Pena <ignacio.pena87@gmail.com>
Subject: [PATCH v2 2/2] staging: rtl8723bs: remove unnecessary commented code in rtl8723b_cmd
Date: Wed, 16 Jul 2025 13:51:13 -0400 [thread overview]
Message-ID: <20250716175113.81519-2-ignacio.pena87@gmail.com> (raw)
In-Reply-To: <20250716175113.81519-1-ignacio.pena87@gmail.com>
From: Ignacio Pena <ignacio.pena87@gmail.com>
Remove commented out code that serves no purpose, as suggested by
Greg KH. This includes both single line comments and block comments
that are not providing useful documentation.
Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
---
Changes in v2:
- Remove entire commented blocks instead of just fixing formatting
- Combined comment removal patches as they serve the same purpose
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
index abc123def..def456abc 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
@@ -78,7 +78,6 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd
else {
memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, 3);
memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer+3, CmdLen-3);
-/* *(u8 *)(&h2c_cmd) |= BIT(7); */
}
*(u8 *)(&h2c_cmd) |= ElementID;
@@ -433,16 +432,6 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapter, u8 psmode)
}
-/* offload to FW if fw version > v15.10
- pmlmeext->DrvBcnEarly = 0;
- pmlmeext->DrvBcnTimeOut =7;
-
- if ((pmlmeext->DrvBcnEarly!= 0Xff) && (pmlmeext->DrvBcnTimeOut!= 0xff))
- u1H2CPwrModeParm[H2C_PWRMODE_LEN-1] = BIT(0) | ((pmlmeext->DrvBcnEarly<<1)&0x0E) |((pmlmeext->DrvBcnTimeOut<<4)&0xf0) ;
-*/
-
- }
-
FillH2CCmd8723B(padapter, H2C_8723B_SET_PWR_MODE, H2C_PWRMODE_LEN, u1H2CPwrModeParm);
}
--
2.39.5
next prev parent reply other threads:[~2025-07-16 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 17:51 [PATCH v2 1/2] staging: rtl8723bs: remove unnecessary braces in rtl8723b_cmd Ignacio Peña
2025-07-16 17:51 ` Ignacio Peña [this message]
2025-07-24 9:28 ` [PATCH v2 2/2] staging: rtl8723bs: remove unnecessary commented code " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716175113.81519-2-ignacio.pena87@gmail.com \
--to=ignacio.pena87@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.